Change import to use type imports for React Native#86
Closed
visormatt wants to merge 2 commits intoduongdev:mainfrom
Closed
Change import to use type imports for React Native#86visormatt wants to merge 2 commits intoduongdev:mainfrom
visormatt wants to merge 2 commits intoduongdev:mainfrom
Conversation
This change updates the imports of the `react-native types` to adhere to TS verbatimModuleSyntax. It looks like the same pattern is applied [icon-base.tsx](https://github.com/duongdev/phosphor-react-native/blob/main/src/lib/icon-base.tsx) as well.
duongdev
approved these changes
Mar 25, 2026
Author
|
Closing a re-opening GH was having some spotty issues last night and the workflow was just hanging. Sorry for the noise .
|
For whatever reason the pipelines never started, hopefully this commit will give it a kick start. Happy to revert it afterwards as well, just lmk.
mrkpatchaa
approved these changes
Mar 28, 2026
mrkpatchaa
added a commit
that referenced
this pull request
Mar 28, 2026
Collaborator
|
Hi @visormatt your changes are now merged. And release 3.0.4 published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change updates the imports of the
react-native typesto adhere to TS verbatimModuleSyntax. It looks like the same pattern is applied icon-base.tsx as well.And thank you for the wonderful library 🙇