Open
Conversation
weavejester
requested changes
Mar 28, 2019
Contributor
weavejester
left a comment
weavejester
left a comment
There was a problem hiding this comment.
This seems reasonable, but I'll need to think about it.
You know that custom reader tags can be specified, right?
src/duct/core.clj
Outdated
| 'duct/include (make-include readers) | ||
| 'duct/resource resource} | ||
| 'duct/resource resource | ||
| 'duct/regex #(Pattern/compile %)} |
Contributor
There was a problem hiding this comment.
Could this be changed to re-compile?
iku000888
force-pushed
the
feature/regex-reader-tag
branch
from
fd56e7f to
dab4953
Compare
Author
Yes and that is what I do right now and works great & happy with that, so it is totally up to you ;) |
iku000888
force-pushed
the
feature/regex-reader-tag
branch
from
dab4953 to
6ccb1ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are libs(e.g. https://github.com/r0man/ring-cors) that require regex patterns to be passed in, and it would be great if I can specify e.g.
#"some-allowed-origin"directly in the config edn file.This however did not work because it is not part of the eden spec.
This PR is the next thing I tried in my project and was pretty happy about it. Would it make sense to have this in duct/core?