forked from datafold/data-diff
-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: populate conftest.py with shared fixtures and auto-skip logic #45
Copy link
Copy link
Open
Labels
P2-mediumMedium priority, next 1-2 monthsMedium priority, next 1-2 monthstechnical-debtTechnical debt itemsTechnical debt itemstestingTest coverage and infrastructureTest coverage and infrastructuretriage
Description
Problem
conftest.py is empty (1 line). All shared test infrastructure lives in common.py using unittest patterns. The CONN_STRINGS dict in common.py:103 silently filters out databases without connection strings — tests pass with zero coverage and no skip messages.
Scope
- Add session-scoped database connection fixtures to conftest.py
- Add custom markers:
pytest.mark.database("postgresql")etc. - Replace silent filter with explicit
pytest.mark.skip(reason="...") - New tests should follow pytest-native style (not unittest.TestCase)
Acceptance Criteria
- conftest.py provides shared fixtures
- Skipped databases show as SKIPPED (not silently filtered)
- pytest output clearly shows which databases were tested vs skipped
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2-mediumMedium priority, next 1-2 monthsMedium priority, next 1-2 monthstechnical-debtTechnical debt itemsTechnical debt itemstestingTest coverage and infrastructureTest coverage and infrastructuretriage