Skip to content

Fix Tumblr fetch when text_only=False#80

Merged
aaronjae22 merged 3 commits intomainfrom
fix/tumblr-fetch-all-post-types
Mar 9, 2026
Merged

Fix Tumblr fetch when text_only=False#80
aaronjae22 merged 3 commits intomainfrom
fix/tumblr-fetch-all-post-types

Conversation

@aaronjae22
Copy link
Collaborator

@aaronjae22 aaronjae22 commented Mar 6, 2026

Calling fetch_social_posting_vertical(text_only=False) returns a 404 from Tumblr's API because the code was sending type= (empty string) as a query parameter.

When text_only=False, omit the type parameter entirely. Tumblr accepts no type to mean "all types" but rejects type=.

Closes #81

Update: This PR also closes #82

@aaronjae22 aaronjae22 requested a review from lisad March 6, 2026 02:35
@aaronjae22 aaronjae22 self-assigned this Mar 6, 2026
@aaronjae22 aaronjae22 merged commit 2ec9a6b into main Mar 9, 2026
1 check passed
@aaronjae22 aaronjae22 deleted the fix/tumblr-fetch-all-post-types branch March 9, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cap Python to <3.14 for pydantic-core compatibility Fix Tumblr fetch when text_only=False

2 participants