Calling of Java 8 method throws a runtime error in Android API < 24#59
Merged
dsrees merged 1 commit intodsrees:masterfrom Jun 14, 2019
Merged
Calling of Java 8 method throws a runtime error in Android API < 24#59dsrees merged 1 commit intodsrees:masterfrom
dsrees merged 1 commit intodsrees:masterfrom
Conversation
Owner
|
👍 good catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was seeing a crash on older Android devices and it turned out to be a subtle destructuring-related issue.
It's pretty easy to reproduce as long as you have the right device (anything less than API 24). I was seeing the exception in the error handling function I register with setDefaultUncaughtExceptionHandler, but if you don't register I expect the app would just crash.
I can't think of a good way to add a unit test because of the platform dependency.