Skip to content

feat(AutoRedirect): set Interval parameter default value to 10m#7818

Merged
ArgoZhang merged 3 commits intomainfrom
feat-auto-redirector
Mar 30, 2026
Merged

feat(AutoRedirect): set Interval parameter default value to 10m#7818
ArgoZhang merged 3 commits intomainfrom
feat-auto-redirector

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Mar 30, 2026

Link issues

fixes #7816

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Remove the hard-coded Interval default on AutoRedirect and apply a 10-minute fallback during parameter initialization when the interval is non-positive.

Copilot AI review requested due to automatic review settings March 30, 2026 08:31
@bb-auto bb-auto bot added the enhancement New feature or request label Mar 30, 2026
@bb-auto bb-auto bot added this to the v10.4.0 milestone Mar 30, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 30, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the AutoRedirect component so the Interval parameter no longer hardcodes a 60-second default at declaration time, instead normalizing it during parameter binding to a 10-minute default when no valid value is provided, and wires this value into the JS initialization as before.

Sequence diagram for AutoRedirect parameter normalization and JS init

sequenceDiagram
    actor BlazorRuntime
    participant AutoRedirect
    participant JSInterop

    BlazorRuntime->>AutoRedirect: set Interval(parameter)
    BlazorRuntime->>AutoRedirect: OnParametersSet()
    AutoRedirect->>AutoRedirect: if Interval <= 0
    AutoRedirect->>AutoRedirect: Interval = 10 * 60 * 1000

    BlazorRuntime->>AutoRedirect: InvokeInitAsync()
    AutoRedirect->>JSInterop: init(Id, Interop, Interval, Lock) via InvokeVoidAsync
Loading

Class diagram for updated AutoRedirect Interval handling

classDiagram
    class BootstrapModuleComponentBase {
        <<abstract>>
        +InvokeVoidAsync(identifier, id, interop, interval, lockMethodName) Task
    }

    class AutoRedirect {
        +int Interval
        +InvokeInitAsync() Task
        +OnParametersSet() void
    }

    BootstrapModuleComponentBase <|-- AutoRedirect

    AutoRedirect : Interval <= 0 => Interval = 10 * 60 * 1000
    AutoRedirect : InvokeInitAsync() calls InvokeVoidAsync(init, Id, Interop, Interval, Lock)
Loading

File-Level Changes

Change Details Files
Change Interval handling from a hardcoded 60s default to a validated, parameter-driven default of 10 minutes when unset or non-positive.
  • Remove the inline default value assignment of 60000 from the Interval parameter so it can be controlled entirely via component parameters.
  • Add an OnParametersSet override that normalizes Interval, setting it to 10 * 60 * 1000 when the provided value is less than or equal to zero, effectively defaulting to 10 minutes.
  • Keep the existing JS initialization call (InvokeInitAsync) to pass the resolved Interval value into the AutoRedirect JavaScript interop as before.
src/BootstrapBlazor/Components/AutoRedirect/AutoRedirect.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#7816 Set the AutoRedirect component's Interval parameter default value to 10 minutes (600000 ms), while still allowing custom values to be provided.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The XML doc comment for Interval still states a default of 60000 ms; please update it to reflect the new 10-minute default and the behavior when non-positive values are supplied.
  • If the intent is to treat Interval <= 0 as an invalid user input that falls back to a default, consider extracting the default value into a named constant/field so it is not duplicated in both code and documentation.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The XML doc comment for `Interval` still states a default of 60000 ms; please update it to reflect the new 10-minute default and the behavior when non-positive values are supplied.
- If the intent is to treat `Interval <= 0` as an invalid user input that falls back to a default, consider extracting the default value into a named constant/field so it is not duplicated in both code and documentation.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (cc7435c) to head (12afdff).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7818   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          764       764           
  Lines        34115     34122    +7     
  Branches      4697      4698    +1     
=========================================
+ Hits         34115     34122    +7     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the AutoRedirect component so its Interval parameter defaults to 10 minutes when not provided, aligning with issue #7816.

Changes:

  • Removed the Interval property initializer.
  • Added OnParametersSet logic to set Interval to 10 minutes when Interval <= 0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ArgoZhang ArgoZhang merged commit 18ee382 into main Mar 30, 2026
4 checks passed
@ArgoZhang ArgoZhang deleted the feat-auto-redirector branch March 30, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(AutoRedirect): set Interval parameter default value to 10m

2 participants