Merged
Conversation
premun
reviewed
Jun 30, 2021
src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/JS/WasmTestCommand.cs
Outdated
Show resolved
Hide resolved
premun
approved these changes
Jun 30, 2021
Member
|
NodeJs is a Host not just Engine, it brings extra APIs. Longer term perspective is that we may need to address feature-set unique to nodeJs, such as different networking stack and filesystem stack, among others. I wonder if we should rather add new Consider unit tests which are 'browser only', those which run with All of that could be answered in the future and we could merge this as is. |
pavelsavara
approved these changes
Jun 30, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
NodeJSengine when running xharness.Why is this needed
I am adding NodeJS support to MONO WASM (dotnet/runtime) and so this change would facilitate the testing as well as future maintenance of this feature.
How is it used
Exactly the same as V8 or any other JavaScript engine.
Example:
XHarness wasm test --app=. --output-directory=".\xharness-output" --engine=NodeJS --js-file=runtime.js -- --run WasmTestRunner.dll System.AppContext.Tests.dll -notrait category=OuterLoop -notrait category=failing(this command runs some of the tests in dotnet/runtime on NodeJS)