[release/8.0-staging][mono][debugger] Fix inspect Span<byte>#99844
Merged
thaystg merged 1 commit intodotnet:release/8.0-stagingfrom Apr 2, 2024
Merged
[release/8.0-staging][mono][debugger] Fix inspect Span<byte>#99844thaystg merged 1 commit intodotnet:release/8.0-stagingfrom
thaystg merged 1 commit intodotnet:release/8.0-stagingfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @thaystg |
lambdageek
approved these changes
Mar 18, 2024
Member
|
@thaystg looks like the bot didn't put the backport template in the description for some reason |
Member
Author
This is because I did it manually. I will add the template and fill it. |
jeffschwMSFT
approved these changes
Mar 18, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 8.0.x
rbhanda
added
Servicing-approved
Contributor
|
@jeffschwMSFT I'd sure love for this to be taken. It's completely blocking testing an android app that I've been (personally) developing. |
Member
|
it is approved for 8.0.5 shipping in May |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #99843 to release/8.0-staging
Customer Impact
Reported by customers in dotnet/android#8792. While debugging a MAUI/Blazor Wasm app and it's paused in a breakpoint/stepping and there is any local that is of type Span the runtime will throw an assertion and finish the debugging session.
Regression
Testing
Risk
Low. The change only checks if the value that is coming from SDB is NULL and then do not throw the assertion.