[browser][MT] Handling blocking wait#99833
Merged
pavelsavara merged 13 commits intodotnet:mainfrom Apr 4, 2024
Merged
Conversation
pavelsavara
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
This was referenced Mar 15, 2024
pavelsavara
force-pushed
the
browser_mt_pnse
branch
2 times, most recently
from
b22e759 to
401ac3c
Compare
pavelsavara
force-pushed
the
browser_mt_pnse
branch
from
401ac3c to
df00d23
Compare
This was referenced Mar 22, 2024
pavelsavara
force-pushed
the
browser_mt_pnse
branch
from
19034d2 to
d65353c
Compare
pavelsavara
force-pushed
the
browser_mt_pnse
branch
from
d65353c to
3a8eaea
Compare
# Conflicts: # src/mono/browser/runtime/loader/config.ts # src/mono/browser/runtime/managed-exports.ts # src/mono/browser/runtime/types/internal.ts
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
31 tasks
This was referenced Apr 2, 2024
This was referenced Apr 2, 2024
maraf
reviewed
Apr 3, 2024
...ervices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSSynchronizationContext.cs
Show resolved
Hide resolved
maraf
approved these changes
Apr 4, 2024
Member
Author
|
All the CI failures are #99888 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.WaitMainThreadingModeandJSThreadInteropModeconfigurationThread.WarnOnBlockingWaitOnJSInteropThreadThrowWhenBlockingWaitmodeJSThreadBlockingModenow could have following valuesPreventSynchronousJSExport- defaultJSExportfrom being called from JavaScript code in UI thread.JSWebWorkersynchronousJSExportalways works.JSWebWorkerblocking .Wait always warns.ThrowWhenBlockingWaitJSExportto be called from JavaScript code also in UI thread..Waitthrows PNSE.JSImportthrows PNSE (because it would deadlock otherwise in 100% cases).JSWebWorkersynchronousJSExportalways works.JSWebWorkerblocking.Waitalways throws PNSE.WarnWhenBlockingWaitJSExportto be called from JavaScript code also in UI thread..Waitwarns.JSImportthrows PNSE (because it would deadlock otherwise in 100% cases).JSWebWorkersynchronousJSExportalways works.JSWebWorkerblocking.Waitalways warns.DangerousAllowBlockingWaitJSExportto be called from JavaScript code, and allows managed code to use blocking.Wait.WaitonPromise/Taskchains could lead to deadlock because JS event loop is not processed and it can't resolve JS promises.JSExportto be called from JavaScript code also in main thread.JSImportthrows PNSE (because it would deadlock otherwise in 100% cases).Contributes to #76958
Contributes to #98652
Contributes to #99951
Fixes #98804
Fixes #97914
Fixes #44622
More scenarios: #93603 (comment)