JIT: Fix Swift multireg stores in presence of GT_RELOAD#99789
Merged
jakobbotsch merged 1 commit intodotnet:mainfrom Mar 15, 2024
Merged
JIT: Fix Swift multireg stores in presence of GT_RELOAD#99789jakobbotsch merged 1 commit intodotnet:mainfrom
GT_RELOAD#99789jakobbotsch merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr jitstress2-jitstressregs |
Member
Author
|
cc @dotnet/jit-contrib PTAL @amanasifkhalid |
|
Azure Pipelines successfully started running 3 pipeline(s). |
amanasifkhalid
approved these changes
Mar 14, 2024
Contributor
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
LGTM if CI passes. Thanks!
Member
Author
|
There is another failure, but it looks LSRA related and unrelated to the specifics of Swift handling. Going to open a separate issue for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally merged #99704 before the jitstressregs jobs I had kicked off were actually done running. This fixes an issue caught by those pipelines.