Enable NativeAOT win-x86 runtime tests by filipnavara · Pull Request #99688 · dotnet/runtime

filipnavara · 2024-03-13T13:33:05Z

See #99688 (comment) for results of the last run.

filipnavara · 2024-03-13T13:45:41Z

Can someone run /azp run runtime-nativeaot-outerloop, please?

jakobbotsch · 2024-03-13T14:20:48Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-03-13T14:20:58Z

Azure Pipelines successfully started running 1 pipeline(s).

filipnavara · 2024-03-14T07:51:39Z

Can I get a re-run please? (Most of the individual commits are submitted as separate PRs; I'll rebase once they land and leave just the YAML changes here.)

jakobbotsch · 2024-03-14T09:17:51Z

/azp run runtime-nativeaot-outerloop

filipnavara · 2024-03-14T10:23:08Z

Remaining failed runtime test should be fixed by #99753. Since the Azure bot didn't respond to the /azp run runtime-nativeaot-outerloop command (😒) I pushed the additional change here as well.

EgorBo · 2024-03-14T13:50:34Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-03-14T13:50:49Z

Azure Pipelines successfully started running 1 pipeline(s).

filipnavara · 2024-03-14T16:46:43Z

Nearly all MSQUIC tests started failing on the linux-arm (32-bit) leg. Wasn't there a MSQUIC update done recently that could have broken something? /cc @ManickaP

MichalPetryka · 2024-03-14T16:48:19Z

Nearly all MSQUIC tests started failing on the linux-arm (32-bit) leg. Wasn't there a MSQUIC update done recently that could have broken something? /cc @ManickaP

#99681

filipnavara · 2024-03-15T08:12:00Z

Rebased over the merged fixes. Can I get a /azp run runtime-nativeaot-outerloop rerun please?

am11 · 2024-03-15T08:15:54Z

@filipnavara, I think being a member of @dotnet/external-ci-access, you can also trigger the leg with /az commands. :)

filipnavara · 2024-03-15T08:18:02Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-03-15T08:18:08Z

Commenter does not have sufficient privileges for PR 99688 in repo dotnet/runtime

filipnavara · 2024-03-15T08:18:19Z

@filipnavara, I think being a member of @dotnet/external-ci-access, you can also trigger the leg with /az commands. :)

Cool. Didn't know that was a thing. Unfortunately, it doesn't work.

khellang · 2024-03-15T08:19:42Z

@am11 And by @'ing that team, you just sent a notification to 166 people 😆 Hello everyone 👋

am11 · 2024-03-15T08:21:38Z

Commenter does not have sufficient privileges for PR 99688 in repo dotnet/runtime

That's sad. I think dotnet/runtime is not part of that group?

And by @'ing that team, you just sent a notification to 166 people 😆 Hello everyone 👋

Ah, sorry I forgot to wrap it in ` 😂 but good things are happening here 😉

filipnavara · 2024-03-15T08:23:10Z

src/tests/JIT/jit64/eh/basics/throwinfinallyintryfilter2.ilproj

  <PropertyGroup>
    <DebugType>PdbOnly</DebugType>
    <Optimize>True</Optimize>
+    <RequiresProcessIsolation>true</RequiresProcessIsolation>


This is unintended change. I'll get rid of it with next rebase.

khellang · 2024-03-15T08:25:25Z

but good things are happening here 😉

For sure. Keep up the good work @filipnavara! 💪😎

jakobbotsch · 2024-03-15T09:01:36Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-03-15T09:01:45Z

Azure Pipelines successfully started running 1 pipeline(s).

filipnavara · 2024-03-20T13:54:38Z

I think the stackunwind for the assembly code also needs to simulate pop of the 16 bytes worth of arguments. It means that you would need to special-case this method.

I think you are right!

An alternative is to move the null check to managed code like I have done in #96916 for CoreCLR. It would allow the interlocked helper to be implemented in C/C++ instead of assembly.

Sounds like a reasonable thing to do. I'll submit a PR later today (at least for moving the null check, and if feasible the move to C++ as well).

MihaZupan · 2024-03-22T14:25:51Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-03-22T14:26:06Z

Azure Pipelines successfully started running 1 pipeline(s).

vcsjones · 2024-03-23T17:54:51Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-03-23T17:55:04Z

Azure Pipelines successfully started running 1 pipeline(s).

filipnavara · 2024-03-23T22:45:23Z

🎉 All the runtime tests passed! 🎉

Libraries tests:

System.IO.Tests.File_GetSetTimes_SafeFileHandle.WritingShouldUpdateWriteTime_After_SetLastAccessTime seems like reoccurrence of Failing test -System.IO.Tests.File_GetSetTimes_SafeFileHandle_Pathless.WritingShouldUpdateWriteTime_After_SetLastAccessTime on windows/x86 #95298
System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async.RequestDuration_ConnectionClosedWhileReceivingHeaders_Recorded is System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker Test failure #96407

filipnavara · 2024-03-28T22:20:47Z

This is finally unblocked since all dependent PRs were merged.

MichalStrehovsky · 2024-04-01T07:53:39Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-04-01T07:53:52Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2024-04-01T07:59:57Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-04-01T08:00:47Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky

Thank you!

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 13, 2024

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 13, 2024

filipnavara added arch-x86 area-NativeAOT-coreclr and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Mar 13, 2024

JulieLeeMSFT added this to the 9.0.0 milestone Mar 13, 2024

build-analysis bot mentioned this pull request Mar 14, 2024

System.DirectoryServices.Protocols.Tests.BerConverterTests.Decode_Bytes_ReturnsExpected failing on Windows x86 #99725

Closed

build-analysis bot mentioned this pull request Mar 14, 2024

Tracking issue for CI build timeouts #76454

Closed

filipnavara force-pushed the win-x86-runtime-tests branch from fac5ada to 1a8860f Compare March 15, 2024 08:08

filipnavara commented Mar 15, 2024

View reviewed changes

filipnavara mentioned this pull request Mar 20, 2024

[NativeAOT] Move Interlocked null checks to managed, RhpLockCmpXchg64 to C #100021

Merged

This was referenced Mar 22, 2024

Assert failure(PID 13812 [0x000035f4], Thread: 14128 [0x3730]): promoted_bytes (heap_number) == promoted #100035

Closed

Failure in GC\API\NoGCRegion\Callback_Svr\Callback_Svr.cmd #100149

Closed

filipnavara force-pushed the win-x86-runtime-tests branch from 67533a1 to 4952a38 Compare March 23, 2024 10:15

filipnavara mentioned this pull request Mar 25, 2024

Build win-x86 NativeAOT runtime pack #100195

Merged

filipnavara added 4 commits March 28, 2024 23:13

Enable NativeAOT/win-x86 Pri0 tests

10d0379

Enable Libs tests

fdd1660

Add x86 into supported platforms to unblock libs build

86c8457

Bump timeout

34b33d1

filipnavara force-pushed the win-x86-runtime-tests branch from 4952a38 to 34b33d1 Compare March 28, 2024 22:14

filipnavara marked this pull request as ready for review March 28, 2024 22:14

filipnavara requested a review from MichalStrehovsky as a code owner March 28, 2024 22:14

Update ILCompilerRIDs.props

9f47aed

build-analysis bot mentioned this pull request Apr 1, 2024

The hosted runner encountered an error while running your job. (Error Type: Disconnect). dotnet/dnceng#1919

Closed

3 tasks

MichalStrehovsky approved these changes Apr 1, 2024

View reviewed changes

MichalStrehovsky merged commit c5200b6 into dotnet:main Apr 1, 2024

matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024

Enable NativeAOT win-x86 runtime tests (dotnet#99688)

a3ebea9

github-actions bot locked and limited conversation to collaborators May 2, 2024

filipnavara deleted the win-x86-runtime-tests branch April 2, 2025 20:12

Conversation

filipnavara commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filipnavara commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakobbotsch commented Mar 13, 2024

Uh oh!

azure-pipelines bot commented Mar 13, 2024

Uh oh!

filipnavara commented Mar 14, 2024

Uh oh!

jakobbotsch commented Mar 14, 2024

Uh oh!

filipnavara commented Mar 14, 2024

Uh oh!

EgorBo commented Mar 14, 2024

Uh oh!

azure-pipelines bot commented Mar 14, 2024

Uh oh!

filipnavara commented Mar 14, 2024

Uh oh!

MichalPetryka commented Mar 14, 2024

Uh oh!

filipnavara commented Mar 15, 2024

Uh oh!

am11 commented Mar 15, 2024

Uh oh!

filipnavara commented Mar 15, 2024

Uh oh!

azure-pipelines bot commented Mar 15, 2024

Uh oh!

filipnavara commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khellang commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

am11 commented Mar 15, 2024

Uh oh!

filipnavara Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

khellang commented Mar 15, 2024

Uh oh!

jakobbotsch commented Mar 15, 2024

Uh oh!

azure-pipelines bot commented Mar 15, 2024

Uh oh!

filipnavara commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MihaZupan commented Mar 22, 2024

Uh oh!

azure-pipelines bot commented Mar 22, 2024

Uh oh!

vcsjones commented Mar 23, 2024

Uh oh!

azure-pipelines bot commented Mar 23, 2024

Uh oh!

filipnavara commented Mar 23, 2024

Uh oh!

filipnavara commented Mar 28, 2024

Uh oh!

MichalStrehovsky commented Apr 1, 2024

Uh oh!

azure-pipelines bot commented Apr 1, 2024

Uh oh!

MichalStrehovsky commented Apr 1, 2024

Uh oh!

azure-pipelines bot commented Apr 1, 2024

Uh oh!

MichalStrehovsky left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

filipnavara commented Mar 13, 2024 •

edited

Loading

filipnavara commented Mar 13, 2024 •

edited

Loading

filipnavara commented Mar 15, 2024 •

edited

Loading

khellang commented Mar 15, 2024 •

edited

Loading

filipnavara commented Mar 20, 2024 •

edited

Loading