Skip to content

Re-enable calendars tests on NativeAOT/ARM32#99595

Merged
jkotas merged 1 commit intodotnet:mainfrom
filipnavara:patch-16
Mar 12, 2024
Merged

Re-enable calendars tests on NativeAOT/ARM32#99595
jkotas merged 1 commit intodotnet:mainfrom
filipnavara:patch-16

Conversation

@filipnavara
Copy link
Member

@filipnavara filipnavara commented Mar 12, 2024

Fixes #98795

Recent fixes for linker thunk generation and unwinding logic seemed to fix the failure. Tested with multiple successful runs on Raspberry Pi hardware.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Mar 12, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 12, 2024
@MichalStrehovsky
Copy link
Member

MichalStrehovsky commented Mar 12, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky
MichalStrehovsky approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM if the CI agrees!

@build-analysis build-analysis bot mentioned this pull request Mar 12, 2024
Closed
@filipnavara
Copy link
Member Author

filipnavara commented Mar 12, 2024 •
edited
Loading

The affected test passed.

The failed one (JIT.CodeGenBringUpTests) runs into stack overflow here (not entirely deterministic, happened in 2/11 attempts):

    frame #127266: 0x00bf7232 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:71
    frame #127267: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #127268: 0x00bcb6c0 JIT.CodeGenBringUpTests`System.Threading.Lock__get_IsFullyInitialized at Lock.NativeAot.cs:103
    frame #127269: 0x00bcbf8a JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnterSlow_0(this=0xf465f064, timeoutMs=1, currentThreadId=<unavailable>) at Lock.cs:337
    frame #127270: 0x00bcbbe0 JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnter_Outlined(this=<unavailable>, timeoutMs=<unavailable>) at Lock.cs:222
    frame #127271: 0x00bcbab8 JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnter_0(this=<unavailable>, millisecondsTimeout=<unavailable>) at Lock.cs:188
    frame #127272: 0x00bf73f0 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__DeadlockAwareAcquire(cctor=System.Runtime.CompilerServices.ClassConstructorRunner_CctorHandle @ 0xff946750, pContext=0x00d80988) at ClassConstructorRunner.cs:148
    frame #127273: 0x00bf7232 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:71
    frame #127274: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #127275: 0x00bcb6c0 JIT.CodeGenBringUpTests`System.Threading.Lock__get_IsFullyInitialized at Lock.NativeAot.cs:103
    frame #127276: 0x00bcbf8a JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnterSlow_0(this=0xf465f064, timeoutMs=1, currentThreadId=<unavailable>) at Lock.cs:337
    frame #127277: 0x00bcbbe0 JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnter_Outlined(this=<unavailable>, timeoutMs=<unavailable>) at Lock.cs:222
    frame #127278: 0x00bcbab8 JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnter_0(this=<unavailable>, millisecondsTimeout=<unavailable>) at Lock.cs:188
    frame #127279: 0x00bf73f0 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__DeadlockAwareAcquire(cctor=System.Runtime.CompilerServices.ClassConstructorRunner_CctorHandle @ 0xff9468e8, pContext=0x00d80988) at ClassConstructorRunner.cs:148
    frame #127280: 0x00bf7232 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:71
    frame #127281: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #127282: 0x00bcb6c0 JIT.CodeGenBringUpTests`System.Threading.Lock__get_IsFullyInitialized at Lock.NativeAot.cs:103
    frame #127283: 0x00bcbf8a JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnterSlow_0(this=0xf45fc9c4, timeoutMs=-1, currentThreadId=<unavailable>) at Lock.cs:337
    frame #127284: 0x00bcba52 JIT.CodeGenBringUpTests`System.Threading.Lock__EnterAndGetCurrentThreadId(this=0xf45fc9c4) at Lock.cs:76
    frame #127285: 0x00c3311e JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner_Cctor__GetCctor(pContext=0x00d80988) at ClassConstructorRunner.cs:286
    frame #127286: 0x00bf7200 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:65
    frame #127287: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #127288: 0x00bcb6c0 JIT.CodeGenBringUpTests`System.Threading.Lock__get_IsFullyInitialized at Lock.NativeAot.cs:103
    frame #127289: 0x00bcbf8a JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnterSlow_0(this=0xf45fc9c4, timeoutMs=-1, currentThreadId=<unavailable>) at Lock.cs:337
    frame #127290: 0x00bcba52 JIT.CodeGenBringUpTests`System.Threading.Lock__EnterAndGetCurrentThreadId(this=0xf45fc9c4) at Lock.cs:76
    frame #127291: 0x00c3311e JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner_Cctor__GetCctor(pContext=0x00d80988) at ClassConstructorRunner.cs:286
    frame #127292: 0x00bf7200 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:65
    frame #127293: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #127294: 0x00bcb6c0 JIT.CodeGenBringUpTests`System.Threading.Lock__get_IsFullyInitialized at Lock.NativeAot.cs:103
    frame #127295: 0x00bcbf8a JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnterSlow_0(this=0xf45fc9c4, timeoutMs=-1, currentThreadId=<unavailable>) at Lock.cs:337
    frame #127296: 0x00bcba52 JIT.CodeGenBringUpTests`System.Threading.Lock__EnterAndGetCurrentThreadId(this=0xf45fc9c4) at Lock.cs:76
    frame #127297: 0x00c3311e JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner_Cctor__GetCctor(pContext=0x00d80988) at ClassConstructorRunner.cs:286
    frame #127298: 0x00bf7200 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:65
    frame #127299: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #127300: 0x00bcb6c0 JIT.CodeGenBringUpTests`System.Threading.Lock__get_IsFullyInitialized at Lock.NativeAot.cs:103
    frame #127301: 0x00bcbf8a JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnterSlow_0(this=0xf465f064, timeoutMs=1, currentThreadId=<unavailable>) at Lock.cs:337
    frame #127302: 0x00bcbbe0 JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnter_Outlined(this=<unavailable>, timeoutMs=<unavailable>) at Lock.cs:222
    frame #127303: 0x00bcbab8 JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnter_0(this=<unavailable>, millisecondsTimeout=<unavailable>) at Lock.cs:188
    frame #127304: 0x00bf73f0 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__DeadlockAwareAcquire(cctor=System.Runtime.CompilerServices.ClassConstructorRunner_CctorHandle @ 0xff946f00, pContext=0x00d80988) at ClassConstructorRunner.cs:148
    frame #127305: 0x00bf7232 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:71
    frame #127306: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #127307: 0x00bcb6c0 JIT.CodeGenBringUpTests`System.Threading.Lock__get_IsFullyInitialized at Lock.NativeAot.cs:103
    frame #127308: 0x00bcbf8a JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnterSlow_0(this=0xf45fc9c4, timeoutMs=-1, currentThreadId=<unavailable>) at Lock.cs:337
    frame #127309: 0x00bcba52 JIT.CodeGenBringUpTests`System.Threading.Lock__EnterAndGetCurrentThreadId(this=0xf45fc9c4) at Lock.cs:76
    frame #127310: 0x00c3311e JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner_Cctor__GetCctor(pContext=0x00d80988) at ClassConstructorRunner.cs:286
    frame #127311: 0x00bf7200 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:65
    frame #127312: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #127313: 0x00bcb6c0 JIT.CodeGenBringUpTests`System.Threading.Lock__get_IsFullyInitialized at Lock.NativeAot.cs:103
    frame #127314: 0x00bcbf8a JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnterSlow_0(this=0xf45fc9c4, timeoutMs=-1, currentThreadId=<unavailable>) at Lock.cs:337
    frame #127315: 0x00bcba52 JIT.CodeGenBringUpTests`System.Threading.Lock__EnterAndGetCurrentThreadId(this=0xf45fc9c4) at Lock.cs:76
    frame #127316: 0x00c3311e JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner_Cctor__GetCctor(pContext=0x00d80988) at ClassConstructorRunner.cs:286
    frame #127317: 0x00bf7200 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:65
    frame #127318: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #127319: 0x00bcb6c0 JIT.CodeGenBringUpTests`System.Threading.Lock__get_IsFullyInitialized at Lock.NativeAot.cs:103
    frame #127320: 0x00bcbf8a JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnterSlow_0(this=0xf45fc9c4, timeoutMs=-1, currentThreadId=<unavailable>) at Lock.cs:337
    frame #127321: 0x00bcba52 JIT.CodeGenBringUpTests`System.Threading.Lock__EnterAndGetCurrentThreadId(this=0xf45fc9c4) at Lock.cs:76
    frame #127322: 0x00c3311e JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner_Cctor__GetCctor(pContext=0x00d80988) at ClassConstructorRunner.cs:286
    frame #127323: 0x00bf7200 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:65
    frame #127324: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #127325: 0x00bcb6c0 JIT.CodeGenBringUpTests`System.Threading.Lock__get_IsFullyInitialized at Lock.NativeAot.cs:103
    frame #127326: 0x00bcbf8a JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnterSlow_0(this=0xf465f064, timeoutMs=1, currentThreadId=<unavailable>) at Lock.cs:337
    frame #127327: 0x00bcbbe0 JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnter_Outlined(this=<unavailable>, timeoutMs=<unavailable>) at Lock.cs:222
    frame #127328: 0x00bcbab8 JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnter_0(this=<unavailable>, millisecondsTimeout=<unavailable>) at Lock.cs:188
    frame #127329: 0x00bf73f0 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__DeadlockAwareAcquire(cctor=System.Runtime.CompilerServices.ClassConstructorRunner_CctorHandle @ 0xff947518, pContext=0x00d80988) at ClassConstructorRunner.cs:148
...
    frame #135748: 0x00bf7232 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:71
    frame #135749: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #135750: 0x00bcb6c0 JIT.CodeGenBringUpTests`System.Threading.Lock__get_IsFullyInitialized at Lock.NativeAot.cs:103
    frame #135751: 0x00bcbff8 JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnterSlow_0(this=0xf465f064, timeoutMs=1, currentThreadId=<unavailable>) at Lock.cs:337
    frame #135752: 0x00bcbbe0 JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnter_Outlined(this=<unavailable>, timeoutMs=<unavailable>) at Lock.cs:222
    frame #135753: 0x00bcbab8 JIT.CodeGenBringUpTests`System.Threading.Lock__TryEnter_0(this=<unavailable>, millisecondsTimeout=<unavailable>) at Lock.cs:188
    frame #135754: 0x00bf73f0 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__DeadlockAwareAcquire(cctor=System.Runtime.CompilerServices.ClassConstructorRunner_CctorHandle @ 0xff9c5710, pContext=0x00d80988) at ClassConstructorRunner.cs:148
    frame #135755: 0x00bf7232 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__EnsureClassConstructorRun(pContext=0x00d80988) at ClassConstructorRunner.cs:71
    frame #135756: 0x00bf7160 JIT.CodeGenBringUpTests`System.Runtime.CompilerServices.ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase(context=<unavailable>, gcStaticBase=0xf65fc418) at ClassConstructorRunner.cs:35
    frame #135757: 0x00bd14d8 JIT.CodeGenBringUpTests`System.Threading.WaitHandle__WaitOneNoCheck(this=<unavailable>, millisecondsTimeout=-1, useTrivialWaits=false, associatedObject=<unavailable>, waitSource=MonitorWait) at WaitHandle.cs:192
    frame #135758: 0x00bd1310 JIT.CodeGenBringUpTests`System.Threading.WaitHandle__WaitOne(this=<unavailable>, millisecondsTimeout=<unavailable>) at WaitHandle.cs:104
    frame #135759: 0x00bcf060 JIT.CodeGenBringUpTests`System.Threading.Thread__JoinInternal(this=<unavailable>, millisecondsTimeout=<unavailable>) at Thread.NativeAot.Unix.cs:82
    frame #135760: 0x00b6cbde JIT.CodeGenBringUpTests`LocallocLarge_d_BringUpTest_LocallocLarge__RunTest(n=<unavailable>) at LocallocLarge.cs:59
    frame #135761: 0x00b6cc08 JIT.CodeGenBringUpTests`LocallocLarge_d_BringUpTest_LocallocLarge__TestEntryPoint at LocallocLarge.cs:67
    frame #135762: 0x00b68a5a JIT.CodeGenBringUpTests`JIT_CodeGenBringUpTests_Program____Main___g__TestExecutor14_0_15(tempLogSw=0xf4648fa4, statsCsvSw=0xf464c640) at FullRunner.g.cs:438
    frame #135763: 0x00b65b02 JIT.CodeGenBringUpTests`JIT_CodeGenBringUpTests_Program___Main__(args=<unavailable>) at FullRunner.g.cs:79
    frame #135764: 0x00cdba30 JIT.CodeGenBringUpTests`JIT_CodeGenBringUpTests__Module___StartupCodeMain at Utilities.cs:71
    frame #135765: 0xf761b3c0 libc.so.6`__libc_start_call_main(main=(libc.so.6`__libc_start_call_main + 140 at libc_start_call_main.h:74:3), argc=-143216640, argv=0x00b11875) at libc_start_call_main.h:58:16
    frame #135766: 0xf761b4c8 libc.so.6`__libc_start_main_impl(main=(JIT.CodeGenBringUpTests`main + 1 at main.cpp:220), argc=1, argv=0xff9c5a64, init=(_rtld_global), fini=(JIT.CodeGenBringUpTests`__libc_csu_fini + 1), rtld_fini=(ld-linux-armhf.so.3`_dl_fini at dl-fini.c:34:3), stack_end=0xff9c5a64) at libc-start.c:360:3
    frame #135767: 0x00b0e994 JIT.CodeGenBringUpTests`_start + 52

@jkotas jkotas mentioned this pull request Mar 12, 2024
Closed
@jkotas jkotas merged commit 9d329b3 into dotnet:main Mar 12, 2024
@jkotas jkotas mentioned this pull request Mar 13, 2024
Closed
@jkotas
Copy link
Member

jkotas commented Mar 13, 2024

The failed one (JIT.CodeGenBringUpTests) runs into stack overflow here (not entirely deterministic, happened in 2/11 attempts):

Opened: #99663 . It does not look Arm32 specific.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@filipnavara filipnavara deleted the patch-16 branch June 5, 2025 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees

No one assigned

Labels

arch-arm32 area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PersianCalendarTests.IsLeapYear failing

3 participants

@filipnavara @MichalStrehovsky @jkotas