[RISC-V] Enable crossgen for corelib#99436
Merged
jkotas merged 1 commit intodotnet:mainfrom Mar 8, 2024
Merged
Conversation
tomeksowi
approved these changes
Mar 8, 2024
yurai007
approved these changes
Mar 8, 2024
gbalykov
approved these changes
Mar 8, 2024
jkotas
approved these changes
Mar 8, 2024
Member
Author
|
@gbalykov IMO, the internal RISC-V CI will fail due to this PR. Please update the CI. Thank you! |
Member
|
@clamp03 thanks, let's see how it goes for a couple of days during the weekend and I'll check on Monday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables crossgen2 for corelib because
Actually, there are still some bugs like #97877, but I beleive that we can fix them soon.
+ To run with crossgened files on RISC-V, we need to disable
EnableWriteXorExecute. (DOTNET_EnableWriteXorExecute=0)Part of #84834
cc @dotnet/samsung