JIT: Move edge likelihood initialization to fgLinkBasicBlocks#99100
Merged
amanasifkhalid merged 2 commits intodotnet:mainfrom Feb 29, 2024
Merged
JIT: Move edge likelihood initialization to fgLinkBasicBlocks#99100amanasifkhalid merged 2 commits intodotnet:mainfrom
amanasifkhalid merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAfter #98993, the logic for initializing edge likelihoods in
|
Contributor
Author
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL |
AndyAyersMS
approved these changes
Feb 29, 2024
Contributor
Author
|
Failure is #98817. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #98993, the logic for initializing edge likelihoods in
fgAddRefPredcan potentially read uninitialized memory by callingBasicBlock::NumSucc. Avoid this by moving the edge likelihood logic tofgLinkBasicBlocks, where we can safely and cheaply determine the number of successors. Also, renameAssertionInfo::m_isNextEdgeAssertionbased on feedback from #98993.