[mono] Add basic ref struct support for generic parameter#99081
Merged
fanyang-mono merged 19 commits intodotnet:mainfrom Mar 13, 2024
Merged
[mono] Add basic ref struct support for generic parameter#99081fanyang-mono merged 19 commits intodotnet:mainfrom
fanyang-mono merged 19 commits intodotnet:mainfrom
Conversation
fanyang-mono
requested review from
lambdageek,
thaystg and
vargaz
as code owners
ghost
added
the
vargaz
approved these changes
Feb 28, 2024
lambdageek
approved these changes
Feb 28, 2024
Member
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
This looks good!
I'm very pleasantly surprised it's such a small change
lambdageek
requested changes
Mar 1, 2024
src/tests/Loader/classloader/generics/ByRefLike/InvalidCSharp.il
Outdated
Show resolved
Hide resolved
Member
|
@fanyang-mono The CoreCLR support, along with more tests, was merged with #98070. We should merge in main and remove the disabled test attributes. |
fanyang-mono
commented
Mar 4, 2024
…s with byreflike type parameter
This was referenced Mar 8, 2024
Member
Author
|
This PR is ready to be reviewed agian. @lambdageek |
Member
Author
|
CI failures are not related to this PR. |
lambdageek
reviewed
Mar 11, 2024
Member
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
I don't understand the generic instance check for load/store static fields
5 tasks
This was referenced Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94421. Fixes #99165
Contributes to #94415
This PR enables ref struct type being used in generic parameters and added/fixed exceptions being thrown when ref struct type being used with box/newobj/static field by Mono JIT/AOT/interpreter.