Cache the InterfaceImplementation for the concrete type that requires the DIM to be kept in DefaultInterfaceImplementations cache#98782
Merged
jtschuster merged 3 commits intodotnet:mainfrom Feb 23, 2024
Conversation
ghost
assigned
jtschuster
changed the title
jtschuster
changed the title
This was referenced Feb 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds off #98513
Separated out the changes related to using the correct InterfaceImplementation in the DefaultInterfaceImplementations cache. Previously, we would cache the InterfaceImpl that pointed to the interface that provided the DIM. It should be the original type that created the need for the DIM.