Add ProducesNetCoreAssets property to Publishing.props#98665
Merged
ViktorHofer merged 3 commits intodotnet:mainfrom Feb 22, 2024
Merged
Add ProducesNetCoreAssets property to Publishing.props#98665ViktorHofer merged 3 commits intodotnet:mainfrom
ViktorHofer merged 3 commits intodotnet:mainfrom
Conversation
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsIssue: #98662
|
Member
|
LGTM. I pushed another commit to remove a stale comment and the not needed publishingversion property. |
ViktorHofer
approved these changes
Feb 22, 2024
Contributor
Author
|
@ViktorHofer I found out this is not enough for runtime since you don't use the default arcade publishing (Publish.proj). I think I can add the manifest data in prepare-artifacts.proj runtime/src/installer/prepare-artifacts.proj Line 106 in 24a9069 NonShipping property
|
Member
Yeah we are very special in that regards unfortunately... Unfortunately I can't help much with that. |
This was referenced Feb 22, 2024
Contributor
Author
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8066100853 |
4 tasks
MilenaHristova
added a commit
that referenced
this pull request
Feb 27, 2024
* add property to publishing.props * rename to ProducesDotNetReleaseShippingAssets * Update Publishing.props --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
4 tasks
MilenaHristova
added a commit
to MilenaHristova/runtime
that referenced
this pull request
Feb 27, 2024
* add property to publishing.props * rename to ProducesDotNetReleaseShippingAssets * Update Publishing.props --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
ViktorHofer
added a commit
that referenced
this pull request
Mar 6, 2024
…t shipped with .NET release (#98991) * Set assets manifest metadata for assets that get shipped with .NET release (#98824) * add metadata to manifest * set in ItemDefinitionGroup * remove from items * comment * Add ProducesNetCoreAssets property to Publishing.props (#98665) * add property to publishing.props * rename to ProducesDotNetReleaseShippingAssets * Update Publishing.props --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
ViktorHofer
added a commit
that referenced
this pull request
Mar 7, 2024
…t shipped with .NET release (#98989) * add metadata to manifest * set in ItemDefinitionGroup * remove from items * comment * Add ProducesNetCoreAssets property to Publishing.props (#98665) * add property to publishing.props * rename to ProducesDotNetReleaseShippingAssets * Update Publishing.props --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> --------- Co-authored-by: MilenaHristova <mhristova@microsoft.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #98662