[RISC-V] Check DivideByZeroException before generating check for unsigned div/mod#98648
Merged
jakobbotsch merged 2 commits intodotnet:mainfrom Feb 22, 2024
Merged
Conversation
…s::DivideByZeroException is present Not doing so caused JITting on FullOpts fail on assert(add->acdUsed) in genJumpToThrowHlpBlk_la when the DivByZero check was optimized out as a result of dotnet#98113
…::genCodeForDivMod
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Detailsnull
|
tomeksowi
changed the title
Bajtazar
approved these changes
Feb 21, 2024
sirntar
approved these changes
Feb 21, 2024
clamp03
approved these changes
Feb 22, 2024
jakobbotsch
approved these changes
Feb 22, 2024
Member
|
Sorry for breaking RISC-V 🙂 |
Member
|
cc @shushanhf LOONGARCH64 can have the same issue. |
Contributor
Thanks very much. |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate check for unsigned divide by zero only when ExceptionSetFlags::DivideByZeroException is present
Not doing so caused JITting on FullOpts fail on assert(add->acdUsed) in genJumpToThrowHlpBlk_la when the DivByZero check was optimized out as a result of #98113
Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @Bajtazar @bartlomiejko @romanzagorowski