[browser] Move reflection from C# to C#98534
Merged
pavelsavara merged 2 commits intodotnet:mainfrom Feb 16, 2024
Merged
Conversation
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsTo address size+perf regression #98391 (comment)
|
lewing
reviewed
Feb 16, 2024
...ropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHostImplementation.cs
Show resolved
Hide resolved
This was referenced Feb 16, 2024
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ilonatommy
approved these changes
Feb 16, 2024
maraf
reviewed
Feb 16, 2024
| { | ||
| throw new ArgumentNullException(nameof(fullyQualifiedName)); | ||
| } | ||
| var (assemblyName, nameSpace, shortClassName, methodName) = ParseFQN(fullyQualifiedName); |
Member
There was a problem hiding this comment.
Since we don't need parsed values in C#. Would it make any difference to parse it in C? Or in JS?
Member
Author
There was a problem hiding this comment.
JS is in different thread, needs to pass via JS interop as C# String
C is in current/managed thread and needs to be UTF8.
I guess this is OK.
To really optimize it we should get rid of reflection and use [UnmanagedCalersOnly] from roslyn code gen. That will require API change tho.
maraf
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address size+perf regression #98391 (comment)