Vectorize TensorPrimitives.PopCount#98281
Merged
stephentoub merged 4 commits intodotnet:mainfrom Feb 16, 2024
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsUse popcount hardware intrinsics to vectorize TensorPrimitives.PopCount for sizeof(T) == 1 on platforms that have intrinsics. I tried doing this more generally on other platforms with: Vector128<byte> lookup = Vector128.Create((byte)0, 1, 1, 2, 1, 2, 2, 3, 1, 2, 2, 3, 2, 3, 3, 4);
Vector128<byte> cnt1 = Vector128.Shuffle(lookup, x.AsByte() & Vector128.Create((byte)0xF));
Vector128<byte> cnt2 = Vector128.Shuffle(lookup, (x.AsByte() >> 4) & Vector128.Create((byte)0xF));
return (cnt1 + cnt2).As<byte, T>();and the equivalent for Vector256/512, but it ended up being ~5x slower than just using the scalar byte.PopCount for each element. I also tried using this with SumAbsoluteDifferences in support of sizeof(T) == 8, and it ended up being an order of magnitude worse.
|
...ries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.netcore.cs
Outdated
Show resolved
Hide resolved
...ries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.netcore.cs
Outdated
Show resolved
Hide resolved
46fdc2f to
e0c3aca
Compare
...ries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.netcore.cs
Show resolved
Hide resolved
...ries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.netcore.cs
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #97193