Remove GetDomain functions on assorted method/type/assembly classes which are always in the single app domain#98135
Merged
elinor-fung merged 6 commits intodotnet:mainfrom Feb 8, 2024
Conversation
ghost
added
the
Member
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
There are several places where BaseDomain::IsAppDomain() is called. Ideally BaseDomain would be an abstract class so that is fine, but what about the SystemDomain. Did we confirm that SystemDomain is never cast to a BaseDomain and passed around?
jkotas
reviewed
Feb 8, 2024
Member
Author
I checked this for the things I touched. |
This was referenced Feb 8, 2024
AaronRobinsonMSFT
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetDomainfunctions onMethodDesc,MethodTable,TypeDesc, andTypeHandle. They always return the single current app domain.GetDomainfunctions and variables onAssembly,DomainAssembly, andModule. The actual domain they are constructed with is always the single current app domain.