Add encoding for ARM64 IF_SVE_CJ_2A instruction group by snickolls-arm · Pull Request #97885 · dotnet/runtime

snickolls-arm · 2024-02-02T17:25:45Z

Adds support for encoding the rev (predicate) instruction.

Matching capstone output:

rev p1.b, p2.b
rev p4.h, p5.h
rev p3.s, p7.s
rev p0.d, p6.d

Contributing towards #94549.

snickolls-arm · 2024-02-02T17:33:29Z

@a74nh @kunalspathak @dotnet/arm64-contrib

ghost · 2024-02-02T17:45:15Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds support for encoding the rev (predicate) instruction.

Matching capstone output:

rev p1.b, p2.b
rev p4.h, p5.h
rev p3.s, p7.s
rev p0.d, p6.d

Contributing towards #94549.

Author:	snickolls-arm
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

amanasifkhalid

LGTM, thank you!

ryujit-bot · 2024-02-02T18:53:23Z

Diff results for #97885

Throughput diffs

Throughput diffs for linux/arm64 ran on linux/x64

MinOpts (-0.00% to +0.01%)

Collection	PDIFF
libraries.pmi.linux.arm64.checked.mch	+0.01%

Throughput diffs for windows/arm64 ran on linux/x64

MinOpts (-0.00% to +0.01%)

Collection	PDIFF
libraries.pmi.windows.arm64.checked.mch	+0.01%

Details here

ryujit-bot · 2024-02-02T19:53:38Z

Diff results for #97885

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)

Collection	PDIFF
libraries.pmi.linux.arm64.checked.mch	+0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)

Collection	PDIFF
libraries.pmi.windows.arm64.checked.mch	+0.01%

Details here

kunalspathak · 2024-02-03T14:51:16Z

@snickolls-arm - Thanks for your contribution. Please resolve the merge conflicts when you get a chance.

ryujit-bot · 2024-02-05T15:01:37Z

Diff results for #97885

Throughput diffs

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)

Collection	PDIFF
libraries.pmi.windows.arm64.checked.mch	-0.01%

Details here

Throughput diffs for linux/arm64 ran on linux/x64

Overall (-0.01% to -0.00%)

Collection	PDIFF
benchmarks.run_pgo.linux.arm64.checked.mch	-0.01%
benchmarks.run.linux.arm64.checked.mch	-0.01%
benchmarks.run_tiered.linux.arm64.checked.mch	-0.01%
libraries_tests.run.linux.arm64.Release.mch	-0.01%
coreclr_tests.run.linux.arm64.checked.mch	-0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch	-0.01%
realworld.run.linux.arm64.checked.mch	-0.01%
libraries.crossgen2.linux.arm64.checked.mch	-0.01%
libraries.pmi.linux.arm64.checked.mch	-0.01%

MinOpts (-0.03% to +0.00%)

Collection	PDIFF
benchmarks.run_pgo.linux.arm64.checked.mch	-0.01%
benchmarks.run.linux.arm64.checked.mch	-0.01%
benchmarks.run_tiered.linux.arm64.checked.mch	-0.01%
libraries_tests.run.linux.arm64.Release.mch	-0.01%
coreclr_tests.run.linux.arm64.checked.mch	-0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch	-0.01%
realworld.run.linux.arm64.checked.mch	-0.03%

FullOpts (-0.01% to -0.00%)

Collection	PDIFF
benchmarks.run_pgo.linux.arm64.checked.mch	-0.01%
benchmarks.run.linux.arm64.checked.mch	-0.01%
benchmarks.run_tiered.linux.arm64.checked.mch	-0.01%
libraries_tests.run.linux.arm64.Release.mch	-0.01%
coreclr_tests.run.linux.arm64.checked.mch	-0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch	-0.01%
realworld.run.linux.arm64.checked.mch	-0.01%
libraries.crossgen2.linux.arm64.checked.mch	-0.01%
libraries.pmi.linux.arm64.checked.mch	-0.01%

Details here

ryujit-bot · 2024-02-05T16:01:48Z

Diff results for #97885

Throughput diffs

Throughput diffs for linux/arm64 ran on linux/x64

Overall (-0.01% to -0.00%)

Collection	PDIFF
benchmarks.run_pgo.linux.arm64.checked.mch	-0.01%
benchmarks.run.linux.arm64.checked.mch	-0.01%
benchmarks.run_tiered.linux.arm64.checked.mch	-0.01%
libraries_tests.run.linux.arm64.Release.mch	-0.01%
coreclr_tests.run.linux.arm64.checked.mch	-0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch	-0.01%
realworld.run.linux.arm64.checked.mch	-0.01%
libraries.crossgen2.linux.arm64.checked.mch	-0.01%
libraries.pmi.linux.arm64.checked.mch	-0.01%

MinOpts (-0.03% to +0.00%)

Collection	PDIFF
benchmarks.run_pgo.linux.arm64.checked.mch	-0.01%
benchmarks.run.linux.arm64.checked.mch	-0.01%
benchmarks.run_tiered.linux.arm64.checked.mch	-0.01%
libraries_tests.run.linux.arm64.Release.mch	-0.01%
coreclr_tests.run.linux.arm64.checked.mch	-0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch	-0.01%
realworld.run.linux.arm64.checked.mch	-0.03%

FullOpts (-0.01% to -0.00%)

Collection	PDIFF
benchmarks.run_pgo.linux.arm64.checked.mch	-0.01%
benchmarks.run.linux.arm64.checked.mch	-0.01%
benchmarks.run_tiered.linux.arm64.checked.mch	-0.01%
libraries_tests.run.linux.arm64.Release.mch	-0.01%
coreclr_tests.run.linux.arm64.checked.mch	-0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch	-0.01%
realworld.run.linux.arm64.checked.mch	-0.01%
libraries.crossgen2.linux.arm64.checked.mch	-0.01%
libraries.pmi.linux.arm64.checked.mch	-0.01%

Details here

ryujit-bot · 2024-02-06T00:04:08Z

Diff results for #97885

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)

Collection	PDIFF
libraries.pmi.linux.arm64.checked.mch	-0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)

Collection	PDIFF
libraries.pmi.windows.arm64.checked.mch	+0.01%

Details here

ryujit-bot · 2024-02-06T01:04:24Z

Diff results for #97885

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)

Collection	PDIFF
libraries.pmi.linux.arm64.checked.mch	-0.01%

Details here

kunalspathak · 2024-02-06T19:18:53Z

@snickolls-arm - could you please resolve the merge conflicts once again? sorry, there is lot of churn in this portion of the code base.

ryujit-bot · 2024-02-07T12:08:54Z

Diff results for #97885

Throughput diffs

Throughput diffs for windows/arm64 ran on linux/x64

MinOpts (-0.01% to +0.00%)

Collection	PDIFF
libraries.pmi.windows.arm64.checked.mch	-0.01%

Details here

snickolls-arm and others added 2 commits February 2, 2024 17:15

Add encoding for ARM64 IF_SVE_CJ_2A instruction group

e37b1a0

Merge branch 'dotnet:main' into github-IF_SVE_CJ_2A

9ec656b

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 2, 2024

snickolls-arm marked this pull request as ready for review February 2, 2024 17:33

kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Feb 2, 2024

amanasifkhalid approved these changes Feb 2, 2024

View reviewed changes

This was referenced Feb 2, 2024

Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049

Closed

System.Net.Security.Tests.SslStreamCertificateContextOcspLinuxTests.FetchOcspResponse_FirstInvalidThenValid test failure #97836

Closed

kunalspathak mentioned this pull request Feb 3, 2024

Arm64: Implement SVE encodings #94549

Closed

kunalspathak approved these changes Feb 3, 2024

View reviewed changes

Merge branch 'main' into github-IF_SVE_CJ_2A

56ece2c

build-analysis bot mentioned this pull request Feb 5, 2024

System.Net.Security.Tests.SslStreamCertificateContextOcspLinuxTests.RefreshOcspResponse_BeforeExpiration test failure #97779

Closed

kunalspathak added 2 commits February 5, 2024 07:54

Merge remote-tracking branch 'origin/main' into github-IF_SVE_CJ_2A

c4f425e

fix merge conflicts

7a303d1

This was referenced Feb 5, 2024

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

superpmi replay jobs are failing #97985

Closed

Tracking issue for CI build timeouts #76454

Closed

snickolls-arm added 2 commits February 7, 2024 10:49

Merge branch 'main' into github-IF_SVE_CJ_2A

6d31fcb

Fix conflicts

ab610b4

kunalspathak merged commit 569b86a into dotnet:main Feb 7, 2024

github-actions bot locked and limited conversation to collaborators Mar 9, 2024

snickolls-arm deleted the github-IF_SVE_CJ_2A branch January 17, 2025 16:07

Conversation

snickolls-arm commented Feb 2, 2024

Uh oh!

snickolls-arm commented Feb 2, 2024

Uh oh!

ghost commented Feb 2, 2024

Uh oh!

amanasifkhalid left a comment

Choose a reason for hiding this comment

Uh oh!

ryujit-bot commented Feb 2, 2024

Throughput diffs

Throughput diffs for linux/arm64 ran on linux/x64

Throughput diffs for windows/arm64 ran on linux/x64

Uh oh!

ryujit-bot commented Feb 2, 2024

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

Throughput diffs for windows/arm64 ran on windows/x64

Uh oh!

kunalspathak commented Feb 3, 2024

Uh oh!

ryujit-bot commented Feb 5, 2024

Throughput diffs

Throughput diffs for windows/arm64 ran on windows/x64

Throughput diffs for linux/arm64 ran on linux/x64

Uh oh!

ryujit-bot commented Feb 5, 2024

Throughput diffs

Throughput diffs for linux/arm64 ran on linux/x64

Uh oh!

ryujit-bot commented Feb 6, 2024

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

Throughput diffs for windows/arm64 ran on windows/x64

Uh oh!

ryujit-bot commented Feb 6, 2024

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

Uh oh!

kunalspathak commented Feb 6, 2024

Uh oh!

ryujit-bot commented Feb 7, 2024

Throughput diffs

Throughput diffs for windows/arm64 ran on linux/x64

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants