Merged
Conversation
Convert Marshal.GetHRForException and Marshal.GetExceptionForHRInternal to QCalls.
davidwrighton
requested changes
Jan 11, 2024
Member
davidwrighton
left a comment
davidwrighton
left a comment
There was a problem hiding this comment.
OffsetOfInternal shouldn't take a field object, it should just be implemented as taking a FieldDesc* as input. Then it won't need anything to do with wonking around with the GC state at all, and can operate entirely in preemptive mode
ghost
added
the
needs-author-action
ghost
removed
the
needs-author-action
Member
Author
@davidwrighton Done. |
jkotas
reviewed
Jan 11, 2024
src/coreclr/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jan 11, 2024
src/coreclr/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jan 11, 2024
davidwrighton
approved these changes
Jan 11, 2024
Member
davidwrighton
left a comment
davidwrighton
left a comment
There was a problem hiding this comment.
Just one more nit... around unnecessary GCX_PREEMP();
elinor-fung
approved these changes
Jan 11, 2024
jkotas
reviewed
Jan 12, 2024
src/coreclr/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.CoreCLR.cs
Outdated
Show resolved
Hide resolved
…ervices/Marshal.CoreCLR.cs
jkotas
reviewed
Jan 12, 2024
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
* Remove HelperMethodFrames from Marshal APIs Convert Marshal.GetHRForException and Marshal.GetExceptionForHRInternal to QCalls. * Convert OffsetOfHelper to QCall * Feedback * Remove GC transition. * Update src/coreclr/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.CoreCLR.cs * Update src/coreclr/vm/marshalnative.cpp --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
MarshalAPI FCalls withHelperMethodFramesinto QCalls.