JIT: Allow BBJ_COND false target to diverge from bbNext in layout optimization phase#96609
Merged
amanasifkhalid merged 21 commits intodotnet:mainfrom Jan 17, 2024
Merged
Conversation
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsNext step for #93020. Working backwards through the JIT flowgraph phases, this change allows
|
This was referenced Jan 8, 2024
Contributor
Author
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AndyAyersMS
approved these changes
Jan 17, 2024
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
Looks like TP is now a non-issue... glad it worked out that way.
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
…imization phase (dotnet#96609) Next step for dotnet#93020. Working backwards through the JIT flowgraph phases, this change allows bbFalseTarget to diverge from bbNext in Compiler::optOptimizeLayout and onwards.
This was referenced Jan 23, 2024
Closed
Closed
Closed
Closed
Closed
Closed
amanasifkhalid
added a commit
to amanasifkhalid/runtime
that referenced
this pull request
Jan 23, 2024
…yout optimization phase (dotnet#96609)" This reverts commit 5598dac.
amanasifkhalid
added a commit
that referenced
this pull request
Jan 29, 2024
Part of #93020. This change adds back in most of #97191 and #96609, except for any significant changes to the flowgraph optimization passes to reduce churn. With this change, the false target of a BBJ_COND can diverge from the next block until Compiler::optOptimizeLayout, in which we reestablish implicit fall-through with fgConnectFallThrough to preserve the existing block reordering behavior. Note that the deferral of these fall-through fixups causes diffs in the edge weights, which can alter the behavior of fgReorderBlocks, hence some of the size regressions
This was referenced Jan 30, 2024
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step for #93020. Working backwards through the JIT flowgraph phases, this change allows
bbFalseTargetto diverge frombbNextinCompiler::optOptimizeLayoutand onwards. This requires some awkward quirking (most of which should be short-lived, while some quirks may stay until we change our block reordering approach), asfgReorderBlocksandfgUpdateFlowGraphPhaseare also called in a few earlier phases.