[workloads] Add the wasi-wasm cross compilers to the workload targets#95170
Merged
lewing merged 2 commits intodotnet:mainfrom Nov 23, 2023
Merged
[workloads] Add the wasi-wasm cross compilers to the workload targets#95170lewing merged 2 commits intodotnet:mainfrom
lewing merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
radical
approved these changes
Nov 23, 2023
lewing
changed the title
lewing
changed the title
steveisok
approved these changes
Nov 23, 2023
|
Thanks @lewing! |
Contributor
|
Does this also need updating for the musl cross compilers? Or is it only relevant on Windows?Sent from my iPhoneOn Nov 23, 2023, at 11:29 AM, Larry Ewing ***@***.***> wrote:
Merged #95170 into main.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
Member
Author
i believe this is the stage that does the windows specific repackaging for VS and the admin installer and doesn't need the cross compiler hosts for other platforms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that the msi.nupkg get published