Skip to content

[release/7.0-staging] Store entry assembly path for easy access for diagnostics#95047

Merged
jeffschwMSFT merged 2 commits intorelease/7.0-stagingfrom
backport/pr-95045-to-release/7.0-staging
Nov 21, 2023
Merged

[release/7.0-staging] Store entry assembly path for easy access for diagnostics#95047
jeffschwMSFT merged 2 commits intorelease/7.0-stagingfrom
backport/pr-95045-to-release/7.0-staging

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 21, 2023

Backport of #95045 to release/7.0-staging

/cc @elinor-fung

Customer Impact

The entry assembly is currently not exposed in a way that is easy to access for diagnostics - for example, crash dumps. This means that for an application started via the dotnet executable (dotnet app.dll), there isn't a good way to determine the managed assembly from a dump - particularly so for a non-heap dump.

See #94474

Testing

Manual validation.

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

- Add `g_EntryAssemblyPath` global variable holding the full path to the entry assembly
  - Set right before loading the entry assembly (so also before startup hooks are run) - NULL if there is no entry assembly
- Ensure value is included dumps
  - For triage dumps, the dumped value is updated to only be the assembly file name instead of the full path
@ghost ghost added the area-VM-coreclr label Nov 21, 2023
@elinor-fung elinor-fung changed the title [release/7.0-staging] [release/8.0-staging] Store entry assembly path for easy access for diagnostics [release/7.0-staging] Store entry assembly path for easy access for diagnostics Nov 21, 2023
@elinor-fung
Copy link
Member

/backport to release/6.0-staging

@github-actions
Copy link
Contributor Author

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/6938665661

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 7.0.x

@ghost
Copy link

ghost commented Nov 21, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #95045 to release/7.0-staging

/cc @elinor-fung

Customer Impact

The entry assembly is currently not exposed in a way that is easy to access for diagnostics - for example, crash dumps. This means that for an application started via the dotnet executable (dotnet app.dll), there isn't a good way to determine the managed assembly from a dump - particularly so for a non-heap dump.

See #94474

Testing

Manual validation.

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, area-Host

Milestone: 7.0.x

@leecow leecow added the Servicing-approved Approved for servicing release label Nov 21, 2023
@leecow leecow modified the milestones: 7.0.x, 7.0.16 Nov 21, 2023
@jeffschwMSFT jeffschwMSFT merged commit f263c81 into release/7.0-staging Nov 21, 2023
@elinor-fung elinor-fung deleted the backport/pr-95045-to-release/7.0-staging branch November 22, 2023 22:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Host Servicing-approved Approved for servicing release Servicing-consider Issue for next servicing release review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments