Implement Interlocked for small types.#92974
Merged
jkotas merged 67 commits intodotnet:mainfrom Jan 25, 2024
Merged
Conversation
Implements Interlocked.CompareExchange/Exchange for byte/sbyte/short/ushort. Uses an intrinsic on CoreCLR x64 and ARM64 and fallbacks for other platforms. Fixes dotnet#64658.
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @mangod9 Issue DetailsImplements Interlocked.CompareExchange/Exchange for byte/sbyte/short/ushort. Uses an intrinsic on CoreCLR x64 and ARM64 and fallbacks for other platforms. Fixes #64658.
|
stephentoub
reviewed
Oct 3, 2023
Klotzi111
reviewed
Oct 5, 2023
This was referenced Oct 5, 2023
This was referenced Oct 6, 2023
Contributor
Author
I've checked that earlier, it calls into a Additionally, on arm32 it gives such warning: |
Member
|
It is a problem with Other operations are implemented using If
|
Contributor
Author
|
I've opened a new issue to track this as this PR doesn't introduce the issue: #97452. |
Contributor
Author
|
|
Member
It does not introduce it, but it makes the problem worse. Could you please replace the new uses of |
Contributor
Author
As I've noted in that issue, those other APIs also use helper calls so I'd assume they have the same issue. |
Diff results for #92974Throughput diffsThroughput diffs for linux/x64 ran on windows/x64Overall (+0.00% to +0.02%)
MinOpts (+0.01% to +0.03%)
FullOpts (+0.00% to +0.01%)
Throughput diffs for windows/x64 ran on windows/x64Overall (-0.01% to -0.00%)
MinOpts (-0.02% to +0.00%)
FullOpts (-0.01% to -0.00%)
Details here Throughput diffs for linux/x64 ran on linux/x64Overall (-0.03% to -0.01%)
MinOpts (-0.07% to -0.04%)
FullOpts (-0.02% to -0.01%)
Details here Throughput diffs for windows/x86 ran on windows/x86Overall (+0.00% to +0.01%)
MinOpts (+0.01% to +0.02%)
FullOpts (+0.00% to +0.01%)
Details here |
Contributor
Author
Diff results for #92974Throughput diffsThroughput diffs for linux/x64 ran on windows/x64Overall (+0.00% to +0.01%)
MinOpts (+0.01% to +0.02%)
FullOpts (+0.00% to +0.01%)
Details here Throughput diffs for linux/x64 ran on linux/x64Overall (-0.02%)
MinOpts (-0.05%)
FullOpts (-0.02%)
Details here |
Diff results for #92974Throughput diffsThroughput diffs for linux/x64 ran on linux/x64Overall (-0.03% to -0.01%)
MinOpts (-0.07% to -0.04%)
FullOpts (-0.02% to -0.01%)
Details here |
3 tasks
Diff results for #92974Throughput diffsThroughput diffs for linux/x64 ran on windows/x64Overall (+0.00% to +0.01%)
MinOpts (+0.01% to +0.03%)
FullOpts (+0.00% to +0.01%)
Throughput diffs for windows/x64 ran on windows/x64Overall (-0.01% to -0.00%)
MinOpts (-0.02% to +0.00%)
FullOpts (-0.01% to -0.00%)
Details here Throughput diffs for windows/x86 ran on windows/x86Overall (+0.00% to +0.01%)
MinOpts (+0.01% to +0.02%)
FullOpts (+0.00% to +0.01%)
Details here Throughput diffs for linux/x64 ran on linux/x64Overall (-0.03% to -0.01%)
MinOpts (-0.07% to -0.04%)
FullOpts (-0.02% to -0.01%)
Details here |
Contributor
Author
|
@jkotas I think the arm32 atomic helper issue should be fixed in a separate PR (I can take a look at using the safe LLVM helpers later today) so this should be ready to merge. |
Member
What was this bug? |
Member
|
/azp run runtime-coreclr outerloop, runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
A missing cast to |
jkotas
approved these changes
Jan 25, 2024
Member
jkotas
left a comment
jkotas
left a comment
There was a problem hiding this comment.
Thank you for making this happen!
VSadov
reviewed
Aug 17, 2024
| public static int CompareExchange(ref int location1, int value, int comparand) | ||
| { | ||
| #if TARGET_X86 || TARGET_AMD64 || TARGET_ARM64 || TARGET_RISCV64 | ||
| return CompareExchange(ref location1, value, comparand); |
Member
There was a problem hiding this comment.
This is a self-referential "must expand" intrinsic now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Interlocked.CompareExchange/Exchange for byte/sbyte/short/ushort.
Uses an intrinsic on CoreCLR x64 and ARM64 and fallbacks for other platforms.
Fixes #64658.