[wasm] Having space in path fails builds by ilonatommy · Pull Request #92399 · dotnet/runtime

ilonatommy · 2023-09-21T06:37:05Z

Investigating #92335.

Change wbt -> wbt artifacts e.g. artifacts/bin/Wasm.Build.Tests/Release/net8.0/browser-wasm/wbt/blz_checkfingerprinting_Debug_gqyxbvpe_hfq -> artifacts/bin/Wasm.Build.Tests/Release/net8.0/browser-wasm/wbt artifacts/blz_checkfingerprinting_Debug_gqyxbvpe_hfq
The change is not in the immediate parent directory but still fails BuildPublishTests.
Repro:
publish with AOT on Windows/Linux/iOS.

error (Windows):

C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\8.0.0-rc.2.23479.6\Sdk\WasmApp.Native.targets(682,5
): error : Precompiling failed for C:\repos\with spaces\obj\Release\net8.0\wasm\for-publish\aot
-in\aot-instances.dll with exit code 1. [C:\repos\with spaces\withspaces.csproj]
C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\8.0.0-rc.2.23479.6\Sdk\WasmApp.Native.targets(682,5
): error : Can not open image C:\repos\with [C:\repos\with spaces\withs
paces.csproj]

in the default WasmDedup=true is caused by incorrect argv parsing in driver.c for arguments with spaces.

When dedup disabled or on Linux, error is:

# project path: /workspaces/spaces/with spaces/withSpaces.csproj
/usr/local/dotnet/7.0.306/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/7.0.13/Sdk/WasmApp.Native.targets(326,5): error : clang version 15.0.0
/usr/local/dotnet/7.0.306/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/7.0.13/Sdk/WasmApp.Native.targets(326,5): error : Target: wasm32-unknown-emscripten
/usr/local/dotnet/7.0.306/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/7.0.13/Sdk/WasmApp.Native.targets(326,5): error : Thread model: posix
/usr/local/dotnet/7.0.306/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/7.0.13/Sdk/WasmApp.Native.targets(326,5): error : InstalledDir: /usr/local/dotnet/7.0.306/packs/Microsoft.NET.Runtime.Emscripten.3.1.12.Sdk.linux-x64/7.0.13/tools/bin 
/usr/local/dotnet/7.0.306/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/7.0.13/Sdk/WasmApp.Native.targets(326,5): error : clang-15: error: no such file or directory: 'spaces/obj/Debug/net7.0/wasm/for-publish' 
/usr/local/dotnet/7.0.306/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/7.0.13/Sdk/WasmApp.Native.targets(326,5): error : emcc: error: '/usr/local/dotnet/7.0.306/packs/Microsoft.NET.Runtime.Emscripten.3.1.12.Sdk.linux-x64/7.0.13/tools/bin/clang -target wasm32-unknown-emscripten -DEMSCRIPTEN -D__EMSCRIPTEN_major__=3 -D__EMSCRIPTEN_minor__=1 -D__EMSCRIPTEN_tiny__=12 -fvisibility=default -mllvm -combiner-global-alias-analysis=false -mllvm -enable-emscripten-cxx-exceptions -mllvm -enable-emscripten-sjlj -mllvm -disable-lsr -Werror=implicit-function-declaration -Xclang -iwithsysroot/include/SDL --sysroot=/usr/local/dotnet/7.0.306/packs/Microsoft.NET.Runtime.Emscripten.3.1.12.Cache.linux-x64/7.0.13/tools/emscripten/cache/sysroot -Xclang -iwithsysroot/include/compat -O0 -v -DDISABLE_PERFTRACING_LISTEN_PORTS=1 -DENABLE_AOT=1 -DDRIVER_GEN=1 -DLINK_ICALLS=1 -DCORE_BINDINGS -DGEN_PINVOKE=1 -emit-llvm "-I/workspaces/spaces/with spaces/obj/Debug/net7.0/wasm/for-publish" -I/usr/local/dotnet/7.0.306/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/7.0.13/runtimes/browser-wasm/native/include/mono-2.0 -I/usr/local/dotnet/7.0.306/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/7.0.13/runtimes/browser-wasm/native/include/wasm -g3 -c /usr/local/dotnet/7.0.306/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/7.0.13/runtimes/browser-wasm/native/src/corebindings.c -o /tmp/tmpuEU9sy.tmp' failed (returned 1)

Repro:
run the last line's command from the above error. The problem is on clang's side, even if we wrap included paths into quotations, like this:

/workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NET.Runtime.Emscripten.3.1.34.Sdk.linux-x64/9.0.0-alpha.1.23523.3/tools/bin/clang -target wasm32-unknown-emscripten -fvisibility=default -mllvm -combiner-global-alias-analysis=false -mllvm -wasm-enable-sjlj -mllvm -disable-lsr -DEMSCRIPTEN -Werror=implicit-function-declaration --sysroot=/workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NET.Runtime.Emscripten.3.1.34.Cache.linux-x64/9.0.0-alpha.1.23523.3/tools/emscripten/cache/sysroot -Xclang -iwithsysroot/include/fakesdl -Xclang -iwithsysroot/include/compat -msimd128 -Oz -g3 -fwasm-exceptions -DDISABLE_PERFTRACING_LISTEN_PORTS=1 -DENABLE_AOT=1 -DDRIVER_GEN=1 -DLINK_ICALLS=1 -DGEN_PINVOKE=1 -emit-llvm "-I'/workspaces/runtime/artifacts/bin/Wasm.Build.Tests/Release/net8.0/browser-wasm/wbt artifacts/5rgnklv4_nwg/obj/Release/net8.0/browser-wasm/wasm/for-publish'" -I'/workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/9.0.0-dev/runtimes/browser-wasm/native/include/mono-2.0' -I'/workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/9.0.0-dev/runtimes/browser-wasm/native/include/wasm' -c /workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/9.0.0-dev/runtimes/browser-wasm/native/src/corebindings.c -o /tmp/tmpsavOEM.tmp

it still splits the input by spaces instead of reading the whole string in the quotation.
Fix:
replacing spaces in _EmccCFlags with "\ " in WasmApp.Native.targets. However, MsBuild does not want to cooperate on that: dotnet/msbuild#3468, dotnet/msbuild#9200

ghost · 2023-09-21T06:37:14Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Investigating #92335.

Change wbt -> wbt artifacts e.g. artifacts/bin/Wasm.Build.Tests/Release/net8.0/browser-wasm/wbt/blz_checkfingerprinting_Debug_gqyxbvpe_hfq -> artifacts/bin/Wasm.Build.Tests/Release/net8.0/browser-wasm/wbt artifacts/blz_checkfingerprinting_Debug_gqyxbvpe_hfq
The change is not in the immediate parent directory but still fails BuildPublishTests on Linux .

Author:	ilonatommy
Assignees:	-
Labels:	`arch-wasm`, `area-Build-mono`
Milestone:	-

ilonatommy · 2023-10-27T13:50:34Z

After escaping spaces the response file for AOT publish:

-Oz
-g
-fwasm-exceptions
-DDISABLE_PERFTRACING_LISTEN_PORTS=1
-DENABLE_AOT=1
-DDRIVER_GEN=1
-DLINK_ICALLS=1
-DGEN_PINVOKE=1
-emit-llvm
-I"/workspaces/runtime/artifacts/bin/Wasm.Build.Tests/Release/net8.0/browser-wasm/wbt\ artifacts/ldcthrrl_sml/obj/Release/net8.0/browser-wasm/wasm/for-publish"
-I"/workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/9.0.0-dev/runtimes/browser-wasm/native/include/mono-2.0"
-I"/workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/9.0.0-dev/runtimes/browser-wasm/native/include/wasm"

The error still persists. Interestingly, emcc moves the quotations when passing arguments to clang, preserving the space escape:

error : emcc: error: '/workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NET.Runtime.Emscripten.3.1.34.Sdk.linux-x64/9.0.0-alpha.1.23523.3/tools/bin/clang -target wasm32-unknown-emscripten -fvisibility=default -mllvm -combiner-global-alias-analysis=false -mllvm -wasm-enable-sjlj -mllvm -disable-lsr -DEMSCRIPTEN -Werror=implicit-function-declaration --sysroot=/workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NET.Runtime.Emscripten.3.1.34.Cache.linux-x64/9.0.0-alpha.1.23523.3/tools/emscripten/cache/sysroot -Xclang -iwithsysroot/include/fakesdl -Xclang -iwithsysroot/include/compat -msimd128 -Oz -g3 -fwasm-exceptions -DDISABLE_PERFTRACING_LISTEN_PORTS=1 -DENABLE_AOT=1 -DDRIVER_GEN=1 -DLINK_ICALLS=1 -DGEN_PINVOKE=1 -emit-llvm "-I/workspaces/runtime/artifacts/bin/Wasm.Build.Tests/Release/net8.0/browser-wasm/wbt\ artifacts/ldcthrrl_sml/obj/Release/net8.0/browser-wasm/wasm/for-publish" -I/workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/9.0.0-dev/runtimes/browser-wasm/native/include/mono-2.0 -I/workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/9.0.0-dev/runtimes/browser-wasm/native/include/wasm -c /workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/9.0.0-dev/runtimes/browser-wasm/native/src/driver.c -o /tmp/tmpTWqAsv.tmp' failed

cc @radekdoulik

radical · 2023-10-31T15:55:16Z

-I"/workspaces/runtime/artifacts/bin/Wasm.Build.Tests/Release/net8.0/browser-wasm/wbt\ artifacts/ldcthrrl_sml/"

Since the path is quoted we shouldn't need to escape space in wbt artifacts.

ilonatommy · 2023-10-31T17:27:46Z

-I"/workspaces/runtime/artifacts/bin/Wasm.Build.Tests/Release/net8.0/browser-wasm/wbt\ artifacts/ldcthrrl_sml/"

Since the path is quoted we shouldn't need to escape space in wbt artifacts.

In the current state we have
-I"/workspaces/runtime/artifacts/bin/Wasm.Build.Tests/Release/net8.0/browser-wasm/wbt artifacts/ldcthrrl_sml/"
Failing. We will need to figure out something else.

Linux fails, test others.

a9a3c09

ilonatommy added arch-wasm WebAssembly architecture area-Build-mono labels Sep 21, 2023

ghost assigned ilonatommy Sep 21, 2023

build-analysis bot mentioned this pull request Sep 21, 2023

Microsoft.DotNet.Build.Tasks.Workloads.Tests.MsiTests.ItCanBuildAManifestMsi test failure in Arcade dotnet/arcade#14046

Closed

ilonatommy added 2 commits October 2, 2023 08:18

Merge branch 'main' into wbt-space-in-path

fca73e1

Fix spaced paths on Unix.

529665b

maraf mentioned this pull request Oct 2, 2023

[wasm] Fix AOT for projects with space in path/name #92880

Closed

Merge branch 'main' into wbt-space-in-path

24d99c7

build-analysis bot mentioned this pull request Oct 26, 2023

Test failure: Wasm.Build.Tests.NativeBuildTests.MonoAOTCross_WorksWithNoTrimming #93522

Closed

Fix spaces for dedup.

39ae63a

build-analysis bot mentioned this pull request Oct 26, 2023

Test_EventSource_EtwManifestGeneration* tests failing in CI #48798

Closed

Escape spaces with backslash.

920563e

Build error

c56be8b

ilonatommy mentioned this pull request Oct 30, 2023

[wasm] Fix AOT publish in paths with space on Windows #94166

Merged

Test only shifted after -I quotations, revert backslash.

28456f4

build-analysis bot mentioned this pull request Oct 31, 2023

[wasm] JSImportExportTest.JsImportTaskTypes - System.ObjectDisposedException #93347

Closed

ilonatommy closed this Nov 1, 2023

ghost locked as resolved and limited conversation to collaborators Dec 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm] Having space in path fails builds#92399

[wasm] Having space in path fails builds#92399
ilonatommy wants to merge 8 commits intodotnet:mainfrom
ilonatommy:wbt-space-in-path

ilonatommy commented Sep 21, 2023 •

edited

Loading

Uh oh!

ghost commented Sep 21, 2023

Uh oh!

ilonatommy commented Oct 27, 2023 •

edited

Loading

Uh oh!

radical commented Oct 31, 2023

Uh oh!

ilonatommy commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

ilonatommy commented Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Sep 21, 2023

Uh oh!

ilonatommy commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

radical commented Oct 31, 2023

Uh oh!

ilonatommy commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

ilonatommy commented Sep 21, 2023 •

edited

Loading

ilonatommy commented Oct 27, 2023 •

edited

Loading