[automated] Merge branch 'release/8.0-rc1' => 'release/8.0'#92346
[automated] Merge branch 'release/8.0-rc1' => 'release/8.0'#92346dotnet-maestro-bot wants to merge 1 commit intodotnet:release/8.0from
Conversation
…ers (dotnet#92317) * Events for IL methods without IL headers Dynamically generated methods like UnsafeAccessor functions are marked as IL, but don't contain an IL header. The lack of header is an indication the IL must be generated at runtime. * Debugger check for no IL header * Update src/coreclr/debug/daccess/stack.cpp Co-authored-by: Tlakaelel Axayakatl Ceja <tlakaelel.ceja@microsoft.com> * Review feedback * Remove redundent calls and another spot to check. * Move header include --------- Co-authored-by: Aaron R Robinson <arobins@microsoft.com> Co-authored-by: Tlakaelel Axayakatl Ceja <tlakaelel.ceja@microsoft.com>
e993824 to
eafb0d6
Compare
carlossanlop
left a comment
There was a problem hiding this comment.
@jeffschwMSFT @mmitche , the change we merged to release/8.0-rc1 is flowing automatically as expected. I want to make sure we do want this flowing to release/8.0. If yes, then keep in mind we do not have this change in the rc2 branch so we might need an extra backport.
If we don't want it in release/8.0, please close this.
|
the change has been in rc2 since Aug 19. if the only change is related to the rc1 fix, then this is not needed. |
|
@jeffschwMSFT If this has been in rc2 since Aug 19 (release/8.0 at that time), what are the diffs from? |
@mmitche I've no idea how this process works or when |
|
I think this is a UX issue and there actually is no diff. release/8.0 already has these changes. Yields no diffs. |
I detected changes in the release/8.0-rc1 branch which have not been merged yet to release/8.0. I'm a robot and am configured to help you automatically keep release/8.0 up to date, so I've opened this PR.
This PR merges commits made on release/8.0-rc1 by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/8.0-rc1-to-release/8.0'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
or if you are using SSH
Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.