JIT: add missing xarch RMW case#92252
Conversation
Handle the case where we're indirectly updating a local with a value that is not a constant. Fixes dotnet#92218.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsHandle the case where we're indirectly updating a local with a value that is not a constant. Fixes #92218.
|
|
@BruceForstall PTAL This is a regression from .NET 7, so we'll need to make the case for a backport. |
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
LGTM
Probably should run jitstress
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The issue looks like the same as #41073, where it seems we elected not to fix it in |
My fix is in jitstress failures also happening in main (#92202 ). |
|
Build analysis doesn't seem to be tracking known jitstress issues, so will have to "merge on red". |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6239547972 |
The issues with the JSON blobs need to have the "Known Build Error" label to be included in the analysis. I've added it to #92202 |
Aha. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
3 participants
Handle the case where we're indirectly updating a local with a value that is not a constant.
Fixes #92218.