[release/8.0] JIT: Initialize jitstdout lazily#92212
Merged
carlossanlop merged 7 commits intodotnet:release/8.0from Sep 18, 2023
Merged
[release/8.0] JIT: Initialize jitstdout lazily#92212carlossanlop merged 7 commits intodotnet:release/8.0from
carlossanlop merged 7 commits intodotnet:release/8.0from
Conversation
Avoid duplicating a handle and doing several I/O operations on the startup path. Fixes dotnet#91856 as a side effect.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #92123 to release/8.0 Customer ImpactThe JIT may crash the process during startup in custom hosting scenarios where TestingManually verified that the JIT code making I/O operations on stdout no longer runs (unless needed, e.g. due to RiskLow, make some code not run during startup/shutdown, and make some mechanical changes in code that does not run in release builds.
|
EgorBo
approved these changes
Sep 18, 2023
jeffschwMSFT
approved these changes
Sep 18, 2023
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. this can be merged when ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #92123 to release/8.0
Customer Impact
The JIT may crash the process during startup in custom hosting scenarios where
stdoutis closed before the JIT is initialized. Customer reported in #91856.Testing
Manually verified that the JIT code making I/O operations on stdout no longer runs (unless needed, e.g. due to
DOTNET_JitDisasmbeing set).Risk
Low, make some code not run during startup/shutdown, and make some mechanical changes in code that does not run in release builds.