[release/8.0] Fix type parameter mapping logic in ILLink/ILCompiler#92139
Merged
carlossanlop merged 4 commits intorelease/8.0from Sep 16, 2023
Merged
[release/8.0] Fix type parameter mapping logic in ILLink/ILCompiler#92139carlossanlop merged 4 commits intorelease/8.0from
carlossanlop merged 4 commits intorelease/8.0from
Conversation
github-actions
bot
requested review from
MichalStrehovsky and
marek-safar
as code owners
ghost
added
the
needs-area-label
marek-safar
added
the
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsBackport of #92088 to release/8.0 /cc @sbomer Customer ImpactFixes a blocking bug that was causing ILLink to crash. The crash can be observed when using code or dependencies with a certain kind of lambda expression usage. Originally reported in #91880, where it was observed in an empty blazor app with a reference to TestingAdded test coverage for this pattern, and verified that the original repro is fixed. RiskLow risk. This only introduces another case to the existing discovery logic.
|
vitek-karas
approved these changes
Sep 15, 2023
jeffschwMSFT
approved these changes
Sep 15, 2023
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. when ready this can be merged
carlossanlop
added
Servicing-approved
Closed
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #92088 to release/8.0
/cc @sbomer
Customer Impact
Fixes a blocking bug that was causing ILLink to crash. The crash can be observed when using code or dependencies with a certain kind of lambda expression usage. Originally reported in #91880, where it was observed in an empty blazor app with a reference to
LanguageExt.Core.Testing
Added test coverage for this pattern, and verified that the original repro is fixed.
Risk
Low risk. This only introduces another case to the existing discovery logic.