Avoid marking property/event attributes multiple times

[sbomer]

This tracks whether properties have been marked yet, and avoids marking them multiple times. Fixes a recursion issue where marking a property can cause marking of attributes which may cause marking of the same property.

I removed the AlreadyMarked assert because #84620 propagates the Kind from methods to properties - so it can look as if a property is being marked from a descriptor the first time it is encountered.

Fixes #92064

Fixes the illink part of #83581. That issue mentions a problem with the analyzer behavior, but the testcase I'm fixing in this PR doesn't seem to show duplicate warnings from the analyzer. Can we consider #83581 fixed by this change?

[ghost]

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This tracks whether properties have been marked yet, and avoids marking them multiple times. Fixes a recursion issue where marking a property can cause marking of attributes which may cause marking of the same property.

I removed the AlreadyMarked assert because #84620 propagates the Kind from methods to properties - so it can look as if a property is being marked from a descriptor the first time it is encountered.

Fixes #92064

Fixes the illink part of #84620. That issue mentions a problem with the analyzer behavior, but the testcase I'm fixing in this PR doesn't seem to show duplicate warnings from the analyzer. Can we consider #83581 fixed by this change?

Author:	sbomer
Assignees:	-
Labels:	linkable-framework, area-Tools-ILLink
Milestone:	-

[sbomer]

@vitek-karas I realized the same bug exists for events so I fixed that the same way - PTAL.

[vitek-karas]

Nice

[sbomer]

/backport to release/8.0

[github-actions]

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6202438968