[release/8.0] Fix queue count in rate limiters#90878
Merged
jeffschwMSFT merged 1 commit intorelease/8.0from Aug 22, 2023
Merged
[release/8.0] Fix queue count in rate limiters#90878jeffschwMSFT merged 1 commit intorelease/8.0from
jeffschwMSFT merged 1 commit intorelease/8.0from
Conversation
ghost
added
the
|
Tagging subscribers to this area: @mangod9 Issue DetailsBackport of #90810 to release/8.0 /cc @BrennanConroy Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
adityamandaleeka
approved these changes
Aug 21, 2023
jeffschwMSFT
approved these changes
Aug 22, 2023
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can merge when ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #90810 to release/8.0
/cc @BrennanConroy
Customer Impact
Nullref in rare cases when canceling queued requests for a lease.
Fixes a regression from an earlier change a couple weeks ago.
Testing
Manual, this is a race condition and not possible to test without adding test only hooks. Verified by using thread freezing in VS to force the race to occur.
Risk
Low. Able to verify the bug before changes and not after. The change is cleaner (IMO) than what we previously had and makes me more confident in the area.