Check for generic structs in "needs marshalling" check#90836
Merged
jtschuster merged 11 commits intodotnet:mainfrom Sep 1, 2023
Merged
Check for generic structs in "needs marshalling" check#90836jtschuster merged 11 commits intodotnet:mainfrom
jtschuster merged 11 commits intodotnet:mainfrom
Conversation
ghost
added
the
Member
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
Can we add a negative test that throws InvalidProgramException with a generic class type?
This was referenced Aug 19, 2023
Open
Member
Author
I don't think we can, the analyzer will create an error for classes and structs with NonBlittable generic parameters. |
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
approved these changes
Aug 21, 2023
src/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
…huster/runtime into CheckGenericStructBlittable
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
jkoritzinsky
approved these changes
Aug 30, 2023
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90828.