[release/8.0] [JIT] ARM64 - Temporary fix for ldp/stp optimizations - with test fix#90758
Merged
carlossanlop merged 7 commits intorelease/8.0from Aug 17, 2023
Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #90700 to release/8.0 /cc @TIHan Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jeffschwMSFT
approved these changes
Aug 17, 2023
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review and we can merge
Contributor
|
@dotnet/jit-contrib this is ready - was already reviewed before |
BruceForstall
approved these changes
Aug 17, 2023
Member
|
CI errors are known issues. |
JulieLeeMSFT
approved these changes
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #90700 to release/8.0
/cc @TIHan
Customer Impact
JIT produces bad code-gen which leads to invalid results.
Testing
Two tests were added to ensure we get the correct results.
Risk
Risk is very low as the likelihood of encountering the original bug was already very low. The change only impacts the original scenario.
Description
Resolves #85765
With the latest, the code-gen is quite different from what was reported in the issue, and therefore doesn't reproduce. But the issue still exists and is able to be reproduced by a different sample: