Skip to content

Comments

[mono][interp] Mask all shift amounts#90666

Merged
BrzVlad merged 2 commits intodotnet:mainfrom
BrzVlad:fix-interp-lshift
Aug 23, 2023
Merged

[mono][interp] Mask all shift amounts#90666
BrzVlad merged 2 commits intodotnet:mainfrom
BrzVlad:fix-interp-lshift

Conversation

@BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Aug 16, 2023

No description provided.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 16, 2023
@ghost ghost assigned BrzVlad Aug 16, 2023
@ghost
Copy link

ghost commented Aug 16, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: BrzVlad
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@SamMonoRT SamMonoRT added area-Codegen-Interpreter-mono and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Aug 16, 2023
@ghost
Copy link

ghost commented Aug 16, 2023

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: BrzVlad
Assignees: BrzVlad
Labels:

area-Codegen-Interpreter-mono
Milestone: -

This was referenced Aug 17, 2023
Closed
Open
@BrzVlad BrzVlad force-pushed the fix-interp-lshift branch from 6169f75 to 417b1d7 Compare August 21, 2023 14:21
@SamMonoRT SamMonoRT changed the title test Mono Interpreter - Mask AllShift amounts Aug 21, 2023
@SamMonoRT SamMonoRT mentioned this pull request Aug 21, 2023
Closed
This was referenced Aug 21, 2023
Closed
Closed
@BrzVlad BrzVlad changed the title Mono Interpreter - Mask AllShift amounts [mono][interp] Mask all shift amounts Aug 22, 2023
@BrzVlad BrzVlad marked this pull request as ready for review August 22, 2023 08:41
@SamMonoRT
Copy link
Member

SamMonoRT commented Aug 22, 2023

/cc @tannergooding

@BrzVlad
Copy link
Member Author

BrzVlad commented Aug 22, 2023

Not sure how relevant this scenario is, but I think we should backport to 8.0 since it is very low risk.

@BrzVlad BrzVlad merged commit 03854e8 into dotnet:main Aug 23, 2023
@BrzVlad
Copy link
Member Author

BrzVlad commented Aug 23, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5953281599

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

@BrzVlad an error occurred while backporting to release/8.0, please check the run log for details!

Error: @BrzVlad is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=BrzVlad

@BrzVlad
Copy link
Member Author

BrzVlad commented Aug 23, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5953485066

@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding tannergooding approved these changes

@kotlarmilos kotlarmilos kotlarmilos approved these changes

@SamMonoRT SamMonoRT SamMonoRT approved these changes

@vargaz vargaz Awaiting requested review from vargaz

Assignees

@BrzVlad BrzVlad

Labels

area-Codegen-Interpreter-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BrzVlad @SamMonoRT @tannergooding @kotlarmilos