only slice SocketAddress on success operation#90284
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is regression from #88970. Change is UpdateReceivedSocketAddress is small cleanup as we do not need to special case it any more. fixes #90125
|
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
outerloop test failures are unrelated. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
This is regression from #88970.
When the SocketPal.TryCompleteReceiveFrom fails e.g. no data yet, we should not Slice the SocketAddress because on next round we would not have buffer to receive to. (as we do in case just bellow)
This was added to avoid tracking SocketAddressLength as separate parameter.
Change is UpdateReceivedSocketAddress is small cleanup as we do not need to special case it any more.
fixes #90125