[Browser][hybrid] Fix tests for NodeJS.#90223
Merged
ilonatommy merged 1 commit intodotnet:mainfrom Aug 9, 2023
Merged
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsPR #90145 revealed failures on Hybrid hosted on NodeJS. The differences in behavior should be removed once we update to node v20.
|
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
approved these changes
Aug 9, 2023
radical
pushed a commit
to radical/runtime
that referenced
this pull request
Sep 1, 2023
radical
added a commit
that referenced
this pull request
Sep 5, 2023
* [wasm] Move helix queues to ubuntu 22.04 * Revert #90223 + fix v8 tests. * CI: update other references for wasm helix images --------- Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #90145 revealed failures on Hybrid hosted on NodeJS. The differences in behavior should be removed once we update to node v20.
The reason for this PR might be unclear as it would seem better to fix the behavior then to change the tests. We have a few cases here:
runtime/docs/design/features/globalization-hybrid-mode.md
Line 317 in 24f1513
so that they would be conscious about the "FirstDayOfWeek" being directly bound to the host's answer to that JS function.
AbbreviatedMonthNamesreturns abbreviated genitive name for browser/v8. Node behaves fine. We are aware of the buggy behavior but due to reasons from previous points we decide to keep uniform and fast preforming code, over fixing the individual host's implementations.