FIX #87983 - Enable events for LogAlways#89326
Merged
davmason merged 1 commit intodotnet:mainfrom Jul 25, 2023
Merged
Conversation
Member
|
Maybe we should add a CLI unit test (under src/tests/tracing) to better cover the different log levels and masks to make sure this doesn't regress? @n77y, something you would be interested in doing? |
Contributor
Author
|
@lateralusX, I can take a look. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro of Issue #87983 demonstrates that when an EventListener enables events for NativeRuntimeEventSource with EventLevel.LogAlways then OnEventWritten receives no events.
With a change in src/native/eventpipe/ep-provider.c most events should fire.
With a change in src/coreclr/vm/eventtrace.cpp the rest should fire.
With a change in System.Private.CoreLib/src/System/Diagnostics/Tracing/EventPipeEventDispatcher.cs LogAlways will be treated as the highest level.
The issue was that the provider's level being LogAlways was not accounted for when enabling events and when firing them.
Test app that is helpful reproing the issue and providing useful information: