[iOS] HybridGlobalization Implement missing cases for GlobalizationNative_GetLocaleInfoString by mkhamoyan · Pull Request #89296 · dotnet/runtime

mkhamoyan · 2023-07-21T11:32:01Z

Contributes to #80689

ghost · 2023-07-21T11:32:14Z

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #83514

Contributes to #80689

Author:	mkhamoyan
Assignees:	-
Labels:	`area-System.Globalization`
Milestone:	-

ghost · 2023-07-21T11:49:56Z

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #83514

Contributes to #80689

Author:	mkhamoyan
Assignees:	mkhamoyan
Labels:	`area-System.Globalization`, `os-ios`, `os-tvos`, `os-maccatalyst`
Milestone:	-

mkhamoyan · 2023-07-24T08:08:47Z

/azp run runtime-ioslike

azure-pipelines · 2023-07-24T08:08:55Z

Azure Pipelines successfully started running 1 pipeline(s).

src/libraries/System.Globalization/tests/CultureInfo/CultureInfoThreeLetterISOInfo.cs

src/native/libs/System.Globalization.Native/pal_locale.m

mkhamoyan · 2023-07-25T07:52:19Z

/azp run runtime-ioslike

azure-pipelines · 2023-07-25T07:52:27Z

Azure Pipelines successfully started running 1 pipeline(s).

src/libraries/System.Globalization/tests/CultureInfo/CultureInfoThreeLetterISOInfo.cs

src/native/libs/System.Globalization.Native/pal_locale.m

mkhamoyan · 2023-07-28T08:07:06Z

/azp run runtime-ioslike

azure-pipelines · 2023-07-28T08:07:14Z

Azure Pipelines successfully started running 1 pipeline(s).

mkhamoyan · 2023-07-28T08:53:34Z

/azp run runtime-ioslike

azure-pipelines · 2023-07-28T08:53:39Z

No commit pushedDate could be found for PR 89296 in repo dotnet/runtime

ilonatommy

Other than the failures, it looks good

mkhamoyan · 2023-07-28T15:43:24Z

/azp run runtime-ioslike

azure-pipelines · 2023-07-28T15:43:37Z

Azure Pipelines successfully started running 1 pipeline(s).

mkhamoyan · 2023-07-31T07:33:36Z

/azp run runtime-ioslike

azure-pipelines · 2023-07-31T07:33:50Z

Azure Pipelines successfully started running 1 pipeline(s).

mkhamoyan · 2023-07-31T15:59:18Z

/azp run runtime-ioslike

azure-pipelines · 2023-07-31T15:59:26Z

Azure Pipelines successfully started running 1 pipeline(s).

kotlarmilos · 2023-08-01T08:12:39Z

src/tests/build.proj

      <LinkerArg Remove="@(_LinkerFlagsToDrop)" />
      <ExtraAppLinkerArgs Include="@(LinkerArg)" />
-      <GlobalizationNativeLibs Include="$(MicrosoftNetCoreAppRuntimePackDir)runtimes/$(TargetOS)-$(TargetArchitecture)/native/icudt.dat" />
+      <GlobalizationNativeLibs Include="$(MicrosoftNetCoreAppRuntimePackDir)runtimes/$(TargetOS)-$(TargetArchitecture)/native/icudt.dat;


Looks good! Can you push your changes to the mirror azdo dotnet/runtime and invoke the iOS perf jobs in the https://dev.azure.com/dnceng/internal/_build/results?buildId=2233228&view=results?

I don't think any additional changes are needed for the sample app, but would be good to confirm that.

https://dev.azure.com/dnceng/internal/_build/results?buildId=2233344&view=results
When it will finish, we can check and proceed with merging this PR.

mkhamoyan · 2023-08-01T10:30:45Z

Failures are not related.

mkhamoyan added 2 commits July 20, 2023 16:37

Cahnges to return missing locale properties

5ac9461

Refactor functions

548e34a

ghost added the area-System.Globalization label Jul 21, 2023

ghost assigned mkhamoyan Jul 21, 2023

mkhamoyan added os-ios Apple iOS os-tvos Apple tvOS os-maccatalyst MacCatalyst OS labels Jul 21, 2023

Order test files and add EnglishName tests

a8976cc

mkhamoyan requested review from akoeplinger, mdh1418 and steveisok July 21, 2023 12:19

build-analysis bot mentioned this pull request Jul 21, 2023

Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBinderTests.GetCanReadStaticProperty failed #88843

Closed

Merge branch 'main' into hybrid_locale_properties

e6a49f1

mkhamoyan added 2 commits July 24, 2023 13:55

update order of LocaleStringData cases

f17d8c0

clean up the code

f032d86

This was referenced Jul 24, 2023

Tracking issue for CI build timeouts #76454

Closed

Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637

Closed

mkhamoyan marked this pull request as ready for review July 24, 2023 12:03

mkhamoyan requested a review from ilonatommy July 24, 2023 12:03

ilonatommy reviewed Jul 24, 2023

View reviewed changes

src/libraries/System.Globalization/tests/CultureInfo/CultureInfoThreeLetterISOInfo.cs Outdated Show resolved Hide resolved

src/native/libs/System.Globalization.Native/pal_locale.m Outdated Show resolved Hide resolved

kotlarmilos mentioned this pull request Jul 24, 2023

[mono] The bitcast test fails with exit code 104 on apple mobile platforms #89385

Closed

build-analysis bot mentioned this pull request Jul 24, 2023

Tests.System.TimeProviderTests.TestProviderTimer test failure #87477

Closed

add whitespace

d800ae6

akoeplinger reviewed Jul 25, 2023

View reviewed changes

Merge branch 'main' into hybrid_locale_properties

4268488

build-analysis bot mentioned this pull request Jul 27, 2023

[WASM][Debugger]Test timed out: DebuggerTests.BreakpointTests.DebuggerTests.BreakpointTests.CreateGoodBreakpoint #89453

Closed

Merge branch 'main' into hybrid_locale_properties

8209fa6

mkhamoyan removed the NO-REVIEW Experimental/testing PR, do NOT review it label Jul 28, 2023

Merge branch 'main' into hybrid_locale_properties

4cf91d2

mkhamoyan requested review from akoeplinger and ilonatommy July 28, 2023 11:10

ilonatommy approved these changes Jul 28, 2023

View reviewed changes

mkhamoyan added 3 commits July 28, 2023 16:05

not run on OSX platform

5afb93a

Rename OSX files to iOS

98c2944

update entrypoints

1234322

mkhamoyan added 2 commits July 31, 2023 16:07

Merge branch 'main' into hybrid_locale_properties

a1eadfa

inlcude icu lib files for nativeaot tests

6aaa76e

mkhamoyan requested a review from kotlarmilos August 1, 2023 07:05

mkhamoyan changed the title ~~[OSX] HybridGlobalization Implement missing cases for GlobalizationNative_GetLocaleInfoString~~ [iOS] HybridGlobalization Implement missing cases for GlobalizationNative_GetLocaleInfoString Aug 1, 2023

kotlarmilos reviewed Aug 1, 2023

View reviewed changes

mkhamoyan merged commit 2ac31f3 into dotnet:main Aug 1, 2023

mkhamoyan deleted the hybrid_locale_properties branch August 1, 2023 10:40

ghost locked as resolved and limited conversation to collaborators Aug 31, 2023

Conversation

mkhamoyan commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 21, 2023

Uh oh!

ghost commented Jul 21, 2023

Uh oh!

mkhamoyan commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

Uh oh!

Uh oh!

mkhamoyan commented Jul 25, 2023

Uh oh!

azure-pipelines bot commented Jul 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkhamoyan commented Jul 28, 2023

Uh oh!

azure-pipelines bot commented Jul 28, 2023

Uh oh!

mkhamoyan commented Jul 28, 2023

Uh oh!

azure-pipelines bot commented Jul 28, 2023

Uh oh!

ilonatommy left a comment

Choose a reason for hiding this comment

Uh oh!

mkhamoyan commented Jul 28, 2023

Uh oh!

azure-pipelines bot commented Jul 28, 2023

Uh oh!

mkhamoyan commented Jul 31, 2023

Uh oh!

azure-pipelines bot commented Jul 31, 2023

Uh oh!

mkhamoyan commented Jul 31, 2023

Uh oh!

azure-pipelines bot commented Jul 31, 2023

Uh oh!

kotlarmilos Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

mkhamoyan Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

mkhamoyan commented Aug 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mkhamoyan commented Jul 21, 2023 •

edited

Loading