Conversation
ericstj
requested review from
MichalStrehovsky,
lewing and
pavelsavara
as code owners
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:System.Runtime.InteropServices.JavaScript.WebWorker</Target> |
There was a problem hiding this comment.
So it looks like this is implementation-only API that's only present in one implementation assembly. Since it's excluded from the ref that means it's not a problem for users. Make the suppression conditional as well so that we don't fail the new unused suppressions check.
Although it looks like it's failing ApiCompat. EagerStaticClassConstructionAttribute can be made private to corelib, we don't use it outside corelib and the only reason why it's public is probably some .NET Native history. DebuggerGuidedStepThroughAttribute is used outside corelib. This attribute is used in pair with System.Diagnostics.DebugAnnotations that is also in the suppression. We could either move this to the plan where we make it private and source include the file from multiple assemblies (these are matched by name, they don't need to be in corelib), or keep the suppression. |
|
We've got some new API compat errors that popped up on Friday. Can those be addressed here as well? |
I'll put a separate PR for those. I think this one is just about ready to merge. Ideally we could also get the new APICompat in build so that we can hold the line on these issues. @ViktorHofer |
Tracking issue: #88675 |
|
The one failure was a test issue which I filed. |
ghost
locked as resolved and limited conversation to collaborators
5 participants
Fix #89206