Fix validation on build

[mapogolions]

Fixes #87429

Let's look at the following example

interface IBar {}
class Bar1 : IBar {}
class Bar2 : IBar {}

services.AddScoped<IBar, Bar1>();  // Slot: 1
services.AddTransient<IBar, Bar2>(); // Slot: 0

var sp = services.BuildServiceProvider(validateScopes: true);
Debug.Assert(sp.GetService<IBar>() is Bar2)

The last implementation will be resolved by convention. For more details see the CallSiteFactory class and the DefaultSlot property. The scope validation is fine with a service lifetime (GetService for Transient service on the Root scope).
But the behavior breaks when we set the ValidateOnBuild property to 'true'. Please see unit tests that reproduce the issue.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Let's look at the following example

interface IBar {}
class Bar1 : IBar {}
class Bar2 : IBar {}

services.AddScoped<IBar, Bar1>();  // Slot: 1
services.AddTransient<IBar, Bar2>(); // Slot: 0

var sp = services.BuildServiceProvider(validateScopes: true);
Debug.Assert(sp.GetService<IBar>() is Bar2)

The last implementation will be resolved by convention. For more details see the CallSiteFactory class and the DefaultSlot property. The scope validation is fine with a service lifetime (GetService for Transient service on the Root scope).
But the behavior changes when we set the ValidateOnBuild property to 'true'. Please see unit tests that reproduce the issue.

Author:	mapogolions
Assignees:	-
Labels:	area-Extensions-DependencyInjection
Milestone:	-

[steveharter]

The call to callSite.Cache.Key should only ever occur once for perf.

[steveharter]

.Invoke() is unnecessary.

[steveharter]

It appears this passes without the changes here. Is that intentional?

[mapogolions]

Yes, It is intentional. It tests the GetCacheKey() private method that replaces ResultCache.None for services. (For instance, IEnumerable<Foo> and IEnumerable<Bar> have the same ResultCache that is equal to ResultCache.None if at least one of the Foo and at least one of the Bar have transient lifetime)

[steveharter]

Let's look at the following example

Please add a corresponding issue and link to it from this PR. Thanks

[mapogolions]

Fix #87429

[steveharter]

Failure on runtime known issue.

[steveharter]

Thanks @mapogolions