[browser] fix legacy interop tests#87001
Merged
pavelsavara merged 4 commits intodotnet:mainfrom Jun 2, 2023
Merged
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBy renaming test project I excluded it from CI in #75122 and it was not running there since.
|
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 1, 2023
Member
Author
maraf
approved these changes
Jun 2, 2023
...es.JavaScript.Legacy.UnitTests/System.Runtime.InteropServices.JavaScript.Legacy.Tests.csproj
Outdated
Show resolved
Hide resolved
radekdoulik
approved these changes
Jun 2, 2023
ilonatommy
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

By renaming test project I unknowingly excluded it from CI in #75122 and it was not running there since.
runtime/src/libraries/tests.proj
Line 574 in 534d1df
mono_wasm_set_timeout_exec->mono_wasm_schedule_timer_tickmono_intern_stringas legacystringToMonoStringInternjs_string_to_mono_stringtostringToMonoStringUnsafeinternalyglobalThis.setTimeoutconsistently_store_string_in_intern_tabletostoreStringInInternTablejs_string_to_mono_string_new_roottostringToMonoStringNewRoot