Add IHostApplicationBuilder interface#86974
Merged
eerhardt merged 2 commits intodotnet:mainfrom Jun 8, 2023
Merged
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting Issue DetailsFix #85486
|
steveharter
reviewed
May 31, 2023
...Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 1, 2023
stephentoub
reviewed
Jun 1, 2023
src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/IConfigurationManager.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 1, 2023
src/libraries/Microsoft.Extensions.Hosting.Abstractions/src/IHostApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 1, 2023
src/libraries/Microsoft.Extensions.Hosting.Abstractions/src/IHostApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jun 1, 2023
ViktorHofer
reviewed
Jun 1, 2023
src/libraries/Microsoft.Extensions.Logging/src/Properties/TypeForwards.cs
Outdated
Show resolved
Hide resolved
eerhardt
force-pushed
the
AddIHostApplicationBuilder
branch
from
d178727 to
e0902fe
Compare
tarekgh
reviewed
Jun 2, 2023
src/libraries/Microsoft.Extensions.Hosting/ref/Microsoft.Extensions.Hosting.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Jun 2, 2023
src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
Jun 2, 2023
ViktorHofer
reviewed
Jun 2, 2023
src/libraries/Microsoft.Extensions.Logging/src/CompatibilitySuppressions.xml
Outdated
Show resolved
Hide resolved
- Move ILoggingBuilder from MS.Ext.Logging to MS.Ext.Logging.Abstractions so IHostApplicationBuilder can reference it. - Add IConfigurationManager and implement it in ConfigurationManager. - Add CompatiibilitySuppressions. These errors are caused by ILoggingBuilder being moved to Logging.Abstractions, and ApiCompat not respecting TypeForwardedTo attributes. Fix dotnet#85486
eerhardt
force-pushed
the
AddIHostApplicationBuilder
branch
from
e0902fe to
75ea342
Compare
ViktorHofer
approved these changes
Jun 3, 2023
halter73
approved these changes
Jun 6, 2023
IEvangelist
reviewed
Jun 6, 2023
...Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration/ref/Microsoft.Extensions.Configuration.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/IHostApplicationBuilderTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/IHostApplicationBuilderTests.cs
Outdated
Show resolved
Hide resolved
bart-vmware
reviewed
Jun 7, 2023
src/libraries/Microsoft.Extensions.Hosting/src/HostApplicationBuilder.cs
Show resolved
Hide resolved
Member
Author
eerhardt
added a commit
to eerhardt/aspnetcore
that referenced
this pull request
Jun 13, 2023
dotnet/runtime#86974 added support for a common interface between HostApplicationBuilder and WebApplicationBuilder. This implements the new interface on WebApplicationBuilder.
eerhardt
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Jun 15, 2023
dotnet/runtime#86974 added support for a common interface between HostApplicationBuilder and WebApplicationBuilder. This implements the new interface on WebApplicationBuilder.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #85486