Fix rounding error in getLikelyClassesOrMethods#86965
Merged
EgorBo merged 6 commits intodotnet:mainfrom Jun 1, 2023
Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIt seems that sometimes public static void Main(string[] args)
{
for (int i = 0; i < 200; i++)
{
Test(new MyClass1());
Test(new MyClass1());
Test(new MyClass1());
Test(new MyClass2());
Test(new MyClass3());
Thread.Sleep(16);
}
}
[MethodImpl(MethodImplOptions.NoInlining)]
static int Test(IValue value) => value.GetValue();- 1) 00007FFF3995A8C0 (MyClass1) [likelihood:50%]
+ 1) 00007FFF3995A8C0 (MyClass1) [likelihood:51%]
2) 00007FFF3995AA88 (MyClass2) [likelihood:37%]
3) 00007FFF3995AC50 (MyClass3) [likelihood:12%]
|
14 tasks
AndyAyersMS
reviewed
May 31, 2023
EgorBo
commented
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that sometimes
getLikelyClassesreports that fallback has e.g. 1% likelihood where in fact it's 0. It happens because of the rounding error accumulated ingetLikelyClassesOrMethods. It prevents JIT from moving that fallback to a cold section.