[CoreCLR/NativeAOT] UnsafeAccessorAttribute non-generic support#86932
Merged
AaronRobinsonMSFT merged 55 commits intodotnet:mainfrom Jun 15, 2023
Merged
[CoreCLR/NativeAOT] UnsafeAccessorAttribute non-generic support#86932AaronRobinsonMSFT merged 55 commits intodotnet:mainfrom
UnsafeAccessorAttribute non-generic support#86932AaronRobinsonMSFT merged 55 commits intodotnet:mainfrom
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Member
Author
6 tasks
jkotas
reviewed
May 31, 2023
jkotas
reviewed
May 31, 2023
This was referenced May 31, 2023
This was referenced May 31, 2023
jkotas
reviewed
May 31, 2023
jkotas
reviewed
May 31, 2023
IDisposable
reviewed
May 31, 2023
IDisposable
reviewed
May 31, 2023
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
IDisposable
reviewed
May 31, 2023
IDisposable
reviewed
May 31, 2023
stephentoub
reviewed
Jun 1, 2023
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Is this any method or just instance method? The naming is strange if it's the latter.
Member
Author
There was a problem hiding this comment.
It is for an instance method. That is what API decided upon. I can go back and ask if you think InstanceMethod is more appropriate?
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
IDisposable
reviewed
Jun 1, 2023
Contributor
IDisposable
left a comment
IDisposable
left a comment
There was a problem hiding this comment.
So reminiscent of the old days ...
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 2, 2023
IDisposable
reviewed
Jun 2, 2023
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorAttribute.cs
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
reviewed
Jun 10, 2023
path has evolved to require exceptions to propagate for generation of typeload exception stub.
jkotas
reviewed
Jun 10, 2023
jkotas
reviewed
Jun 10, 2023
jkotas
reviewed
Jun 10, 2023
jkotas
reviewed
Jun 11, 2023
Add test for validation
Added tests for pointer types and declaration name lookup.
back when supported is added.
custom modifiers during method lookup.
jkotas
reviewed
Jun 13, 2023
signature match.
Remove unmanage resource string and move it to SPCL Share the AmbiguousMatchException message between NativeAOT and CoreCLR.
jkotas
approved these changes
Jun 14, 2023
Member
jkotas
left a comment
jkotas
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your work on this feature!
Member
Author
|
@MichalStrehovsky Can you take another look at the NativeAOT portions? I'd like a sign off from you too with respect to how this is implemented there. |
IDisposable
reviewed
Jun 14, 2023
AaronRobinsonMSFT
changed the title
UnsafeAccessorAttribute non-generic supportUnsafeAccessorAttribute non-generic support
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #86161