Skip to content

[mono][debugger] Support new JMC#86815

Closed
thaystg wants to merge 9 commits intodotnet:mainfrom
thaystg:thays_support_new_jmc2
Closed

[mono][debugger] Support new JMC#86815
thaystg wants to merge 9 commits intodotnet:mainfrom
thaystg:thays_support_new_jmc2

Conversation

@thaystg
Copy link
Member

@thaystg thaystg commented May 26, 2023

Not sure if this is the best approach yet, but for now is working.

@thaystg thaystg requested a review from lambdageek May 26, 2023 22:02
@ghost ghost added the area-Debugger-mono label May 26, 2023
@ghost ghost assigned thaystg May 26, 2023
@ghost
Copy link

ghost commented May 26, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Not sure if this is the best approach yet, but for now is working.

Author: thaystg
Assignees: thaystg
Labels:

area-Debugger-mono

Milestone: -

@thaystg
Copy link
Member Author

thaystg commented May 26, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg
Copy link
Member Author

thaystg commented May 29, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg thaystg marked this pull request as ready for review June 6, 2023 16:40
@thaystg thaystg requested a review from marek-safar as a code owner June 6, 2023 16:40
@thaystg
Copy link
Member Author

thaystg commented Jun 6, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

g_assert (*step_thread_id);
err = get_object (*step_thread_id, (MonoObject**)&step_thread);
if (err != ERR_NONE) {
g_free (req);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious - why is this freed in this code path, but not for the others in this function?

@stephentoub
Copy link
Member

@thaystg, are you still working on this? The last update was over a year ago. Should it be closed?

@thaystg
Copy link
Member Author

thaystg commented Jul 22, 2024

We can close.

@thaystg thaystg closed this Jul 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants