Avoid generic virtual methods in enum infrastructure#83063
Merged
MichalStrehovsky merged 2 commits intodotnet:mainfrom Mar 7, 2023
Merged
Avoid generic virtual methods in enum infrastructure#83063MichalStrehovsky merged 2 commits intodotnet:mainfrom
MichalStrehovsky merged 2 commits intodotnet:mainfrom
Conversation
ghost
assigned
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsAfter @EgorBo's #83054 it became realistic to remove the type loader from a hello world app. The comparers logic was keeping type loader around no matter what, but comparers are now preinitialized. This avoidable use of generic virtual methods is another thing keeping the type loader around. As you can see in the commit timestamp, I've been sitting on this change for 2 months. Cc @dotnet/ilc-contrib
|
stephentoub
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After @EgorBo's #83054 it became realistic to remove the type loader from a hello world app. The comparers logic was keeping type loader around no matter what, but comparers are now preinitialized.
This avoidable use of generic virtual methods is another thing keeping the type loader around. As you can see in the commit timestamp, I've been sitting on this change for 2 months.
Cc @dotnet/ilc-contrib