Remove duplicate android and wasm yaml templates to run the runtime tests after a "global-build" build step.#80157
Merged
jkoritzinsky merged 2 commits intodotnet:mainfrom Jan 4, 2023
Conversation
…ests after a "global-build" build step.
Member
Author
|
/azp list |
|
Tagging subscribers to this area: @directhex Issue DetailsI'm planning on utilizing this template in #74623 with CoreCLR and I noticed that we had two very similar copies. I figured it was a good idea to collapse them into a single copy and make it work for CoreCLR for at least simple cases.
|
Member
Author
|
/azp run runtime-android, runtime-androidemulator |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
Member
Author
|
/azp run runtime-android, runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Jan 4, 2023
Closed
Contributor
|
I merged the wasm template into build-runtime-tests-and-send-to-helix.yml but I guess I didn't think to also merge in the android one. Thanks for cleaning that up. |
naricc
approved these changes
Jan 4, 2023
Member
Author
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Failure is #79874. Merging this in to unblock my other work. |
ghost
locked as resolved and limited conversation to collaborators
Copilot AI
added a commit
that referenced
this pull request
Feb 21, 2026
Recognize SUB(CheckedBound, X) <relop> CNS patterns in assertion propagation and extend MergeEdgeAssertions to handle signed comparisons where op1VN is ADD(normalLclVN, constant). This enables the JIT to eliminate redundant bounds checks when user code performs manual bounds checking like: if ((index < 0) || ((array.Length - index) < 2)) throw; return (array[index], array[index + 1]); Fixes #80157 Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm planning on utilizing this template in #74623 with CoreCLR and I noticed that we had two very similar copies. I figured it was a good idea to collapse them into a single copy and make it work for CoreCLR for at least simple cases.